freqtrade/freqtrade

View on GitHub
freqtrade/rpc/external_message_consumer.py

Summary

Maintainability
B
4 hrs
Test Coverage

File external_message_consumer.py has 300 lines of code (exceeds 250 allowed). Consider refactoring.
Open

"""
ExternalMessageConsumer module

Main purpose is to connect to external bot's message websocket to consume data
from it
Severity: Minor
Found in freqtrade/rpc/external_message_consumer.py - About 3 hrs to fix

    Function shutdown has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def shutdown(self):
            """
            Shutdown the loop, thread, and tasks
            """
            if self._thread and self._loop:
    Severity: Minor
    Found in freqtrade/rpc/external_message_consumer.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _consume_analyzed_df_message has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def _consume_analyzed_df_message(self, producer_name: str, message: WSMessageSchema):
            try:
                df_message = WSAnalyzedDFMessage.model_validate(message.model_dump())
            except ValidationError as e:
                logger.error(f"Invalid message from `{producer_name}`: {e}")
    Severity: Minor
    Found in freqtrade/rpc/external_message_consumer.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status