Sign upLogin

freshmindpl/wyszukiwarkaregon

View on GitHub
Star
src/Service.php

Summary

Maintainability
A
0 mins
Test Coverage

Remove error control operator '@' on line 262.
Open

    private function normalizeResponse($response)
    {
        $json = json_decode($response, true);

        if ($json !== null) {
Severity: Minor
Found in src/Service.php by phpmd

ErrorControlOperator

Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

Example

function foo($filePath) {
    $file = @fopen($filPath); // hides exceptions
    $key = @$array[$notExistingKey]; // assigns null to $key
}

Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

Avoid variables with short names like $e. Configured minimum length is 3.
Open

            $e = get_object_vars($element);
Severity: Minor
Found in src/Service.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

There are no issues that match your filters.

Category
Status