Sign upLogin

frontyard/cordova-plugin-exoplayer

View on GitHub
Star

Showing 33 of 53 total issues

Method execute has 150 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    @Override
    public boolean execute(final String action, final JSONArray data, final CallbackContext callbackContext) throws JSONException {
        try {
            final Plugin self = this;
            if (action.equals("show")) {
Severity: Major
Found in src/android/Plugin.java - About 6 hrs to fix

    Method execute has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
    Open

        @Override
    public boolean execute(final String action, final JSONArray data, final CallbackContext callbackContext) throws JSONException {
        try {
            final Plugin self = this;
            if (action.equals("show")) {
    Severity: Minor
    Found in src/android/Plugin.java - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File Player.java has 357 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*
 The MIT License (MIT)

 Copyright (c) 2017 Nedim Cholich
    Severity: Minor
    Found in src/android/Player.java - About 4 hrs to fix

      Player has 35 methods (exceeds 20 allowed). Consider refactoring.
      Open

      public class Player {
    public static final String TAG = "ExoPlayerPlugin";
    private final Activity activity;
    private final CallbackContext callbackContext;
    private final Configuration config;
      Severity: Minor
      Found in src/android/Player.java - About 4 hrs to fix

        Method setupBar has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
        Open

            private static void setupBar(SimpleExoPlayerView parentView, Activity activity, JSONObject controller) {
        String streamTitle = controller.optString("streamTitle", null);
        String streamDescription = controller.optString("streamDescription", null);
        String streamImage = controller.optString("streamImage", null);
        String textColor = controller.optString("textColor");
        Severity: Minor
        Found in src/android/LayoutProvider.java - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method playerErrorEvent has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
        Open

            public static JSONObject playerErrorEvent(ExoPlayer player, ExoPlaybackException origin, String message) {
        int type = 0;
        Map<String, String> map = new HashMap<String, String>();
        map.put("eventType", "PLAYER_ERROR_EVENT");
        Severity: Minor
        Found in src/android/Payload.java - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method setupButtons has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
        Open

            private static void setupButtons(SimpleExoPlayerView parentView, Activity activity, JSONObject controller) {
        String packageName = activity.getPackageName();
        String buttonsColor = controller.optString("buttonsColor");

        JSONObject buttonsConfig = controller.optJSONObject("controlIcons");
        Severity: Minor
        Found in src/android/LayoutProvider.java - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method setupBar has 50 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private static void setupBar(SimpleExoPlayerView parentView, Activity activity, JSONObject controller) {
        String streamTitle = controller.optString("streamTitle", null);
        String streamDescription = controller.optString("streamDescription", null);
        String streamImage = controller.optString("streamImage", null);
        String textColor = controller.optString("textColor");
        Severity: Minor
        Found in src/android/LayoutProvider.java - About 2 hrs to fix

          Method playerErrorEvent has 42 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public static JSONObject playerErrorEvent(ExoPlayer player, ExoPlaybackException origin, String message) {
        int type = 0;
        Map<String, String> map = new HashMap<String, String>();
        map.put("eventType", "PLAYER_ERROR_EVENT");
          Severity: Minor
          Found in src/android/Payload.java - About 1 hr to fix

            Method getMediaSource has 39 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                private MediaSource getMediaSource(Uri uri, DefaultBandwidthMeter bandwidthMeter) {
        String userAgent = Util.getUserAgent(this.activity, config.getUserAgent());
        Handler mainHandler = new Handler();
        int connectTimeout = config.getConnectTimeout();
        int readTimeout = config.getReadTimeout();
            Severity: Minor
            Found in src/android/Player.java - About 1 hr to fix

              Method setupButtons has 29 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  private static void setupButtons(SimpleExoPlayerView parentView, Activity activity, JSONObject controller) {
        String packageName = activity.getPackageName();
        String buttonsColor = controller.optString("buttonsColor");

        JSONObject buttonsConfig = controller.optJSONObject("controlIcons");
              Severity: Minor
              Found in src/android/LayoutProvider.java - About 1 hr to fix

                Method preparePlayer has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    private void preparePlayer(Uri uri) {
        int audioFocusResult = setupAudio();
        String audioFocusString = audioFocusResult == AudioManager.AUDIOFOCUS_REQUEST_FAILED ?
                "AUDIOFOCUS_REQUEST_FAILED" :
                "AUDIOFOCUS_REQUEST_GRANTED";
                Severity: Minor
                Found in src/android/Player.java - About 1 hr to fix

                  Avoid deeply nested control flow statements.
                  Open

                                          if (null == buttonUrl || buttonUrl.equals("null")) { // Again, why is this a String "null"?
                            // Image is set to null, remove it from view.
                            imageButton.setVisibility(View.GONE);
                            ((ViewGroup) imageButton.getParent()).removeView(imageButton);
                        }
                  Severity: Major
                  Found in src/android/LayoutProvider.java - About 45 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                    return true;
                    Severity: Major
                    Found in src/android/Plugin.java - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                          return false;
                      Severity: Major
                      Found in src/android/Plugin.java - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                        return true;
                        Severity: Major
                        Found in src/android/Plugin.java - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                          return true;
                          Severity: Major
                          Found in src/android/Plugin.java - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                                return false;
                            Severity: Major
                            Found in src/android/Plugin.java - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Open

                                              return true;
                              Severity: Major
                              Found in src/android/Plugin.java - About 30 mins to fix

                                Avoid too many return statements within this method.
                                Open

                                                    return false;
                                Severity: Major
                                Found in src/android/Plugin.java - About 30 mins to fix
                                  Severity
                                  Category
                                  Status
                                  Source
                                  Language