Sign upLogin

ftlabs/big-ft

View on GitHub
Star

Showing 29 of 29 total issues

Function __bigFT has 331 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const __bigFT = (function (){

    const updateInterval = 60 * 1000;
    const lastUpdated = document.getElementsByClassName('last-updated')[0];
    const interstitial = new SVGLoader( document.getElementById( 'loader' ), { speedIn : 700, easingIn : mina.easeinout } );
Severity: Major
Found in client/src/main.js - About 1 day to fix

    Function exports has a Cognitive Complexity of 82 (exceeds 5 allowed). Consider refactoring.
    Open

    module.exports = (function ($){

    $.fn.ticker = function (options) {
        const settings = jQuery.extend({
            pxpersec: 150
    Severity: Minor
    Found in client/src/js/ticker.js - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function exports has 149 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    module.exports = (function ($){

    $.fn.ticker = function (options) {
        const settings = jQuery.extend({
            pxpersec: 150
    Severity: Major
    Found in client/src/js/ticker.js - About 5 hrs to fix

      File main.js has 408 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      /* global $, mina */
/* eslint-env browser */
/* eslint strict:0, no-console:0 */
'use strict';
global.$ = global.jQuery = require('jquery');
      Severity: Minor
      Found in client/src/main.js - About 5 hrs to fix

        Function ticker has 139 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            $.ticker = function (el, settings) {

        let addqueue = [];
        let removequeue = [];
        let numSegs;
        Severity: Major
        Found in client/src/js/ticker.js - About 5 hrs to fix

          Function topStories has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
          Open

          module.exports = function topStories (startFrom, numberOfArticles, edition, organisation) {
    'use strict';

    if (isNaN(startFrom)) {
        startFrom = 0;
          Severity: Minor
          Found in server/lib/topStories.js - About 4 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              return fetch(topStoriesUrl + '?startFrom=' + offset + '&numberOfArticles=' + amount + edition + organisation, {
        headers: timestampHeader()
    })
    .then(function (response) {
        return response.json().then(function (data) {
          Severity: Major
          Found in client/src/main.js and 1 other location - About 3 hrs to fix
          client/src/main.js on lines 87..101

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 98.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              return fetch(searchStoriesUrl + '?startFrom=' + offset + '&numberOfArticles=' + amount + '&keyword=' + term, {
        headers: timestampHeader()
    })
    .then(function (response) {
        return response.json().then(function (data) {
          Severity: Major
          Found in client/src/main.js and 1 other location - About 3 hrs to fix
          client/src/main.js on lines 69..83

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 98.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function topStories has 70 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          module.exports = function topStories (startFrom, numberOfArticles, edition, organisation) {
    'use strict';

    if (isNaN(startFrom)) {
        startFrom = 0;
          Severity: Major
          Found in server/lib/topStories.js - About 2 hrs to fix

            Function updateContent has 64 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                function updateContent () {
        const qp = getQueryParams();
        const primaryStoriesPromise = getStories(qp.primaryType, qp.primaryOffset, qp.primaryMax, {
            term: qp.primarySearch,
            edition: qp.edition,
            Severity: Major
            Found in client/src/main.js - About 2 hrs to fix

              Function slide has 63 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                      function slide () {
            let widths;
            const contWidth = elcont.width();

            // Copy each segment over the one preceding it
              Severity: Major
              Found in client/src/js/ticker.js - About 2 hrs to fix

                Function __bigFT has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
                Open

                const __bigFT = (function (){

    const updateInterval = 60 * 1000;
    const lastUpdated = document.getElementsByClassName('last-updated')[0];
    const interstitial = new SVGLoader( document.getElementById( 'loader' ), { speedIn : 700, easingIn : mina.easeinout } );
                Severity: Minor
                Found in client/src/main.js - About 2 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function prepareMainStories has 41 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    function prepareMainStories (stories){

        return new Promise(function (resolve, reject){

            const media = document.createElement('div');
                Severity: Minor
                Found in client/src/main.js - About 1 hr to fix

                  Function exports has 39 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  module.exports = (keyword, startFrom, numberOfArticles) => {
    const searchPayload = {
        queryString: keyword,
        queryContext : {
            curations : [ 'ARTICLES' ]
                  Severity: Minor
                  Found in server/lib/search.js - About 1 hr to fix

                    Function fetchArticlesByOrganisation has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                            organisationPromise = co(function * fetchArticlesByOrganisation () {

            const id = yield fetch('https://next.ft.com/search-suggestions?flatten=true&limit=1&exclude=special&q=' + organisation)
            .then(ensureGoodResponse)
            .then(response => response.json())
                    Severity: Minor
                    Found in server/lib/topStories.js - About 1 hr to fix

                      Function initialise has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          function initialise (){

        const currentTimezone = detectTimezone();
        const clockExistsForTimezone = checkForClock(currentTimezone);
                      Severity: Minor
                      Found in client/src/main.js - About 1 hr to fix

                        Function exports has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                        module.exports = function (article) {
    'use strict';

    const headline = article.title.title;
    const lastPublishDateTime = article.lifecycle.lastPublishDateTime;
                        Severity: Minor
                        Found in server/lib/viewModel.js - About 1 hr to fix

                          Function _animateSVG has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                          Open

                          SVGLoader.prototype._animateSVG = function( dir, callback ) {
    var self = this;
    var pos = 0;
    var steps = dir === 'out' ? this.closingSteps : this.openingSteps;
    var stepsTotal = dir === 'out' ? this.closingStepsTotal : this.openingStepsTotal;
                          Severity: Minor
                          Found in client/src/js/svgloader.js - About 1 hr to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                          function ensureGoodResponse (response) {
    if (!response.ok) {
        return response.text().then(text => {
            throw Error(text);
        });
                          Severity: Major
                          Found in server/lib/search.js and 1 other location - About 1 hr to fix
                          server/lib/topStories.js on lines 15..23

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 55.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                          function ensureGoodResponse (response) {
    if (!response.ok) {
        return response.text().then(text => {
            throw Error(text);
        });
                          Severity: Major
                          Found in server/lib/topStories.js and 1 other location - About 1 hr to fix
                          server/lib/search.js on lines 9..17

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 55.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Severity
                          Category
                          Status
                          Source
                          Language