fucongcong/framework

View on GitHub
core/Group/Cache/StaticCacheService.php

Summary

Maintainability
A
0 mins
Test Coverage
<?php
 
namespace Group\Cache;
 
class StaticCacheService
{
Spaces must be used to indent lines; tabs are not allowed
protected static $store = [];
 
Spaces must be used to indent lines; tabs are not allowed
/**
* 设置一个静态缓存
*
* @param string key
* @param string|array|object value
* @param boolean canUnset 能否释放
*/
The method set has a boolean flag argument $canUnset, which is a certain sign of a Single Responsibility Principle violation.
Spaces must be used to indent lines; tabs are not allowed
public function set($key, $value, $canUnset = true)
Spaces must be used to indent lines; tabs are not allowed
{
Spaces must be used to indent lines; tabs are not allowed
if ($canUnset) {
Spaces must be used to indent lines; tabs are not allowed
self::$store[0][$key] = $value;
The method set uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Spaces must be used to indent lines; tabs are not allowed
} else {
Spaces must be used to indent lines; tabs are not allowed
self::$store[1][$key] = $value;
Spaces must be used for alignment; tabs are not allowed
Spaces must be used to indent lines; tabs are not allowed
Whitespace found at end of line
}
Spaces must be used for alignment; tabs are not allowed
}
 
Spaces must be used for alignment; tabs are not allowed
/**
* 获取一个静态缓存
*
* @param string key
* @param default
* @return val
*/
Spaces must be used for alignment; tabs are not allowed
public function get($key, $default = null)
Spaces must be used for alignment; tabs are not allowed
{
Spaces must be used for alignment; tabs are not allowed
Inline control structures are not allowed
if (isset(self::$store[0][$key])) return self::$store[0][$key];
Spaces must be used for alignment; tabs are not allowed
Inline control structures are not allowed
if (isset(self::$store[1][$key])) return self::$store[1][$key];
Spaces must be used for alignment; tabs are not allowed
return $default;
Spaces must be used for alignment; tabs are not allowed
}
 
Spaces must be used for alignment; tabs are not allowed
/**
* 刷新可释放的静态缓存
*
*/
Spaces must be used for alignment; tabs are not allowed
public function flush()
Spaces must be used for alignment; tabs are not allowed
{
Spaces must be used for alignment; tabs are not allowed
self::$store[0] = [];
Spaces must be used for alignment; tabs are not allowed
}
 
Spaces must be used for alignment; tabs are not allowed
/**
* 刷新所有静态缓存
*
*/
Spaces must be used for alignment; tabs are not allowed
public function flushAll()
Spaces must be used for alignment; tabs are not allowed
{
Spaces must be used for alignment; tabs are not allowed
self::$store = [];
Spaces must be used for alignment; tabs are not allowed
}
}