fucongcong/framework

View on GitHub
core/Group/Common/ArrayToolkit.php

Summary

Maintainability
A
1 hr
Test Coverage

Showing 68 of 68 total issues

Function filter has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

public static function filter(array $array, array $specialValues)
{
$filtered = array();
foreach ($specialValues as $key => $value) {
if (!array_key_exists($key, $array)) {
Severity: Minor
Found in core/Group/Common/ArrayToolkit.php - About 1 hr to fix

Function changes has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

public static function changes(array $before, array $after)
{
$changes = array('before' => array(), 'after' => array());
foreach ($after as $key => $value) {
if (!isset($before[$key])) {
Severity: Minor
Found in core/Group/Common/ArrayToolkit.php - About 25 mins to fix

The method filter uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

} else {
$filtered[$key] = (string) $array[$key];
}
Severity: Minor
Found in core/Group/Common/ArrayToolkit.php by phpmd

Expected "function abc(...)"; found "function abc (...)"
Open

public static function index (array $array, $name)

Expected 0 spaces before opening parenthesis; 1 found
Open

public static function index (array $array, $name)

Spaces must be used to indent lines; tabs are not allowed
Open

{

Spaces must be used to indent lines; tabs are not allowed
Open

}

Spaces must be used to indent lines; tabs are not allowed
Open

}

Spaces must be used to indent lines; tabs are not allowed
Open

public static function column(array $array, $columnName)

Spaces must be used to indent lines; tabs are not allowed
Open

public static function requireds(array $array, array $keys)

Spaces must be used to indent lines; tabs are not allowed
Open

return true;

Spaces must be used to indent lines; tabs are not allowed
Open

}

Spaces must be used to indent lines; tabs are not allowed
Open

if (!array_key_exists($key, $array)) {

Spaces must be used to indent lines; tabs are not allowed
Open

$filtered[$key] = (bool) $array[$key];

Spaces must be used to indent lines; tabs are not allowed
Open

$column = array();

Spaces must be used to indent lines; tabs are not allowed
Open

if (!array_key_exists($key, $array)) {

Spaces must be used to indent lines; tabs are not allowed
Open

}

Spaces must be used to indent lines; tabs are not allowed
Open

$filtered = array();

Spaces must be used to indent lines; tabs are not allowed
Open

$filtered[$key] = (array) $array[$key];

Spaces must be used to indent lines; tabs are not allowed
Open

} elseif (is_int($value)) {

Spaces must be used to indent lines; tabs are not allowed
Open

{

Spaces must be used to indent lines; tabs are not allowed
Open

} elseif (is_float($value)) {

Spaces must be used to indent lines; tabs are not allowed
Open

return $filtered;

Spaces must be used to indent lines; tabs are not allowed
Open

}

Spaces must be used to indent lines; tabs are not allowed
Open

return $column;

Spaces must be used to indent lines; tabs are not allowed
Open

unset($array[$key]);

Spaces must be used to indent lines; tabs are not allowed
Open

$changes = array('before' => array(), 'after' => array());

Spaces must be used to indent lines; tabs are not allowed
Open

$changes['before'][$key] = $before[$key];

Spaces must be used to indent lines; tabs are not allowed
Open

if (is_array($value)) {

Spaces must be used to indent lines; tabs are not allowed
Open

$filtered[$key] = (int) $array[$key];

Spaces must be used to indent lines; tabs are not allowed
Open

if (empty($filtered[$key])) {

Spaces must be used to indent lines; tabs are not allowed
Open

}

Spaces must be used to indent lines; tabs are not allowed
Open

return $array;

Spaces must be used to indent lines; tabs are not allowed
Open

continue;

Spaces must be used to indent lines; tabs are not allowed
Open

} else {

Spaces must be used to indent lines; tabs are not allowed
Open

}

Spaces must be used to indent lines; tabs are not allowed
Open

{

Spaces must be used to indent lines; tabs are not allowed
Open

foreach ($array as $item) {

Spaces must be used to indent lines; tabs are not allowed
Open

$changes['after'][$key] = $value;

Spaces must be used to indent lines; tabs are not allowed
Open

if (empty($array)) {

Spaces must be used to indent lines; tabs are not allowed
Open

}

Spaces must be used to indent lines; tabs are not allowed
Open

foreach ($specialValues as $key => $value) {

Spaces must be used to indent lines; tabs are not allowed
Open

} elseif (is_bool($value)) {

Spaces must be used to indent lines; tabs are not allowed
Open

if (!in_array($key, $keys)) {

Spaces must be used to indent lines; tabs are not allowed
Open

}

Spaces must be used to indent lines; tabs are not allowed
Open

}

Spaces must be used to indent lines; tabs are not allowed
Open

}

Spaces must be used to indent lines; tabs are not allowed
Open

foreach (array_keys($array) as $key) {

Spaces must be used to indent lines; tabs are not allowed
Open

}

Spaces must be used to indent lines; tabs are not allowed
Open

public static function changes(array $before, array $after)

Spaces must be used to indent lines; tabs are not allowed
Open

if (!isset($before[$key])) {

Spaces must be used to indent lines; tabs are not allowed
Open

if ($value != $before[$key]) {

Spaces must be used to indent lines; tabs are not allowed
Open

}

Spaces must be used to indent lines; tabs are not allowed
Open

return false;

Spaces must be used to indent lines; tabs are not allowed
Open

}

Spaces must be used to indent lines; tabs are not allowed
Open

{

Spaces must be used to indent lines; tabs are not allowed
Open

foreach ($keys as $key) {

Spaces must be used to indent lines; tabs are not allowed
Open

}

Spaces must be used to indent lines; tabs are not allowed
Open

continue;

Spaces must be used to indent lines; tabs are not allowed
Open

$filtered[$key] = (float) $array[$key];

Spaces must be used to indent lines; tabs are not allowed
Open

foreach ($after as $key => $value) {

Spaces must be used to indent lines; tabs are not allowed
Open

return $changes;

Spaces must be used to indent lines; tabs are not allowed
Open

$filtered[$key] = $value;

Spaces must be used to indent lines; tabs are not allowed
Open

return array();

Spaces must be used to indent lines; tabs are not allowed
Open

public static function parts(array $array, array $keys)

Spaces must be used to indent lines; tabs are not allowed
Open

}

Spaces must be used to indent lines; tabs are not allowed
Open

}

Spaces must be used to indent lines; tabs are not allowed
Open

$filtered[$key] = (string) $array[$key];

There are no issues that match your filters.

Category
Status