Sign upLogin

fujaba/NetworkParser

View on GitHub
Star

Showing 4,645 of 4,645 total issues

These nested if statements could be combined
Open

                        if (itemOther.getClazz() == assocOther.getClazz() && item.getClazz() == assoc.getClazz()) {
                            add = false;
                            if (assocOther.name() != null && assoc.name() == null) {
                                if (itemOther.getType() == AssociationTypes.EDGE
                                        && item.getType() == AssociationTypes.ASSOCIATION) {
Severity: Minor
Found in src/main/java/de/uniks/networkparser/graph/GraphEntity.java by pmd

CollapsibleIfStatements

Since: PMD 3.1

Priority: Medium

Categories: Style

Remediation Points: 50000

Sometimes two consecutive 'if' statements can be consolidated by separating their conditions with a boolean short-circuit operator.

Example:

void bar() {
 if (x) { // original implementation
 if (y) {
 // do stuff
 }
 }
}

void bar() {
 if (x && y) { // optimized implementation
 // do stuff
 }
}

These nested if statements could be combined
Open

                if (this.children instanceof Annotation) {
                    ((Annotation) this.children).setParentNode(null);
                    this.children = null;
                }
Severity: Minor
Found in src/main/java/de/uniks/networkparser/graph/GraphMember.java by pmd

CollapsibleIfStatements

Since: PMD 3.1

Priority: Medium

Categories: Style

Remediation Points: 50000

Sometimes two consecutive 'if' statements can be consolidated by separating their conditions with a boolean short-circuit operator.

Example:

void bar() {
 if (x) { // original implementation
 if (y) {
 // do stuff
 }
 }
}

void bar() {
 if (x && y) { // optimized implementation
 // do stuff
 }
}

Ensure you override both equals() and hashCode()
Open

    public boolean equals(Object obj) {
Severity: Minor
Found in src/main/java/de/uniks/networkparser/json/JsonObject.java by pmd

OverrideBothEqualsAndHashcode

Since: PMD 0.4

Priority: Medium

Categories: Style

Remediation Points: 50000

Override both public boolean Object.equals(Object other), and public int Object.hashCode(), or override neither. Even if you are inheriting a hashCode() from a parent class, consider implementing hashCode and explicitly delegating to your superclass.

Example:

public class Bar { // poor, missing a hashcode() method
 public boolean equals(Object o) {
 // do some comparison
 }
}

public class Baz { // poor, missing an equals() method
 public int hashCode() {
 // return some hash value
 }
}

public class Foo { // perfect, both methods provided
 public boolean equals(Object other) {
 // do some comparison
 }
 public int hashCode() {
 // return some hash value
 }
}

These nested if statements could be combined
Open

      if (a instanceof String && b instanceof String) {
        return ((String) a).equalsIgnoreCase((String) b);
      }
Severity: Minor
Found in src/main/java/de/uniks/networkparser/list/AbstractArray.java by pmd

CollapsibleIfStatements

Since: PMD 3.1

Priority: Medium

Categories: Style

Remediation Points: 50000

Sometimes two consecutive 'if' statements can be consolidated by separating their conditions with a boolean short-circuit operator.

Example:

void bar() {
 if (x) { // original implementation
 if (y) {
 // do stuff
 }
 }
}

void bar() {
 if (x && y) { // optimized implementation
 // do stuff
 }
}

These nested if statements could be combined
Open

            if (children != null) {
                if (children instanceof CompareTo) {
//                    CompareTo.
                }
                return children.update(value);
Severity: Minor
Found in src/main/java/de/uniks/networkparser/logic/VersionCondition.java by pmd

CollapsibleIfStatements

Since: PMD 3.1

Priority: Medium

Categories: Style

Remediation Points: 50000

Sometimes two consecutive 'if' statements can be consolidated by separating their conditions with a boolean short-circuit operator.

Example:

void bar() {
 if (x) { // original implementation
 if (y) {
 // do stuff
 }
 }
}

void bar() {
 if (x && y) { // optimized implementation
 // do stuff
 }
}

These nested if statements could be combined
Open

                if (association.getType().equals(AssociationTypes.ASSOCIATION) == false) {
                    return false;
                }
Severity: Minor
Found in src/main/java/de/uniks/networkparser/parser/differ/RemoveCondition.java by pmd

CollapsibleIfStatements

Since: PMD 3.1

Priority: Medium

Categories: Style

Remediation Points: 50000

Sometimes two consecutive 'if' statements can be consolidated by separating their conditions with a boolean short-circuit operator.

Example:

void bar() {
 if (x) { // original implementation
 if (y) {
 // do stuff
 }
 }
}

void bar() {
 if (x && y) { // optimized implementation
 // do stuff
 }
}

These nested if statements could be combined
Open

            if (features.match(Feature.SETCLASS, null) == false) {
                return null;
            }
Severity: Minor
Found in src/main/java/de/uniks/networkparser/parser/java/JavaSetCreator.java by pmd

CollapsibleIfStatements

Since: PMD 3.1

Priority: Medium

Categories: Style

Remediation Points: 50000

Sometimes two consecutive 'if' statements can be consolidated by separating their conditions with a boolean short-circuit operator.

Example:

void bar() {
 if (x) { // original implementation
 if (y) {
 // do stuff
 }
 }
}

void bar() {
 if (x && y) { // optimized implementation
 // do stuff
 }
}

These nested if statements could be combined
Open

            if(GraphUtil.isGenerate(item)) {
              return withGraph(value, null);
            }
Severity: Minor
Found in src/main/java/de/uniks/networkparser/xml/HTMLEntity.java by pmd

CollapsibleIfStatements

Since: PMD 3.1

Priority: Medium

Categories: Style

Remediation Points: 50000

Sometimes two consecutive 'if' statements can be consolidated by separating their conditions with a boolean short-circuit operator.

Example:

void bar() {
 if (x) { // original implementation
 if (y) {
 // do stuff
 }
 }
}

void bar() {
 if (x && y) { // optimized implementation
 // do stuff
 }
}

These nested if statements could be combined
Open

            if (this.friends.remove(item))
            {
               item.withoutFriends(this);
               firePropertyChange(PROPERTY_FRIENDS, item, null);
            }
Severity: Minor
Found in src/test/java/de/uniks/networkparser/test/model/Student.java by pmd

CollapsibleIfStatements

Since: PMD 3.1

Priority: Medium

Categories: Style

Remediation Points: 50000

Sometimes two consecutive 'if' statements can be consolidated by separating their conditions with a boolean short-circuit operator.

Example:

void bar() {
 if (x) { // original implementation
 if (y) {
 // do stuff
 }
 }
}

void bar() {
 if (x && y) { // optimized implementation
 // do stuff
 }
}

These nested if statements could be combined
Open

                if (this.cargos.remove(item)) {
                    item.setBank(null);
                    getPropertyChangeSupport().firePropertyChange(PROPERTY_CARGOS, item, null);
                }
Severity: Minor
Found in src/test/java/de/uniks/networkparser/test/model/ferryman/Bank.java by pmd

CollapsibleIfStatements

Since: PMD 3.1

Priority: Medium

Categories: Style

Remediation Points: 50000

Sometimes two consecutive 'if' statements can be consolidated by separating their conditions with a boolean short-circuit operator.

Example:

void bar() {
 if (x) { // original implementation
 if (y) {
 // do stuff
 }
 }
}

void bar() {
 if (x && y) { // optimized implementation
 // do stuff
 }
}

These nested if statements could be combined
Open

                if (this.students.remove(item)) {
                    item.withIn(null);
                }
Severity: Minor
Found in src/test/java/org/sdmlib/test/examples/studyrightWithAssignments/model/Room.java by pmd

CollapsibleIfStatements

Since: PMD 3.1

Priority: Medium

Categories: Style

Remediation Points: 50000

Sometimes two consecutive 'if' statements can be consolidated by separating their conditions with a boolean short-circuit operator.

Example:

void bar() {
 if (x) { // original implementation
 if (y) {
 // do stuff
 }
 }
}

void bar() {
 if (x && y) { // optimized implementation
 // do stuff
 }
}

These nested if statements could be combined
Open

                if (child.has(HTMLEntity.KEY_SRC) == false) {
                    this._execute(child.getValue(), false);
                }
Severity: Minor
Found in src/main/java/de/uniks/networkparser/ext/javafx/JavaAdapter.java by pmd

CollapsibleIfStatements

Since: PMD 3.1

Priority: Medium

Categories: Style

Remediation Points: 50000

Sometimes two consecutive 'if' statements can be consolidated by separating their conditions with a boolean short-circuit operator.

Example:

void bar() {
 if (x) { // original implementation
 if (y) {
 // do stuff
 }
 }
}

void bar() {
 if (x && y) { // optimized implementation
 // do stuff
 }
}

These nested if statements could be combined
Open

            if (ReflectionLoader.CHANGELISTENER.isAssignableFrom(listener.getClass())) {
                listeners.remove(listener);
            }
Severity: Minor
Found in src/main/java/de/uniks/networkparser/ext/javafx/ModelListenerProperty.java by pmd

CollapsibleIfStatements

Since: PMD 3.1

Priority: Medium

Categories: Style

Remediation Points: 50000

Sometimes two consecutive 'if' statements can be consolidated by separating their conditions with a boolean short-circuit operator.

Example:

void bar() {
 if (x) { // original implementation
 if (y) {
 // do stuff
 }
 }
}

void bar() {
 if (x && y) { // optimized implementation
 // do stuff
 }
}

These nested if statements could be combined
Open

      if (minCapacity > elements.length) {
        int newSize = minCapacity + minCapacity / 2 + 5;
        resizeSmall(newSize);
        return newSize;
      }
Severity: Minor
Found in src/main/java/de/uniks/networkparser/list/AbstractArray.java by pmd

CollapsibleIfStatements

Since: PMD 3.1

Priority: Medium

Categories: Style

Remediation Points: 50000

Sometimes two consecutive 'if' statements can be consolidated by separating their conditions with a boolean short-circuit operator.

Example:

void bar() {
 if (x) { // original implementation
 if (y) {
 // do stuff
 }
 }
}

void bar() {
 if (x && y) { // optimized implementation
 // do stuff
 }
}

These nested if statements could be combined
Open

            if (parent instanceof AbstractList<?>) {
                AbstractList<?> collection = (AbstractList<?>) parent;
                collection.add(pos, content);
            }
Severity: Minor
Found in src/main/java/de/uniks/networkparser/parser/ExcelRow.java by pmd

CollapsibleIfStatements

Since: PMD 3.1

Priority: Medium

Categories: Style

Remediation Points: 50000

Sometimes two consecutive 'if' statements can be consolidated by separating their conditions with a boolean short-circuit operator.

Example:

void bar() {
 if (x) { // original implementation
 if (y) {
 // do stuff
 }
 }
}

void bar() {
 if (x && y) { // optimized implementation
 // do stuff
 }
}

These nested if statements could be combined
Open

                if (logger != null) {
                    logger.debug(this, "parsing", "Parsing: " + getCurrentLine());
                }
Severity: Minor
Found in src/main/java/de/uniks/networkparser/parser/ParserEntity.java by pmd

CollapsibleIfStatements

Since: PMD 3.1

Priority: Medium

Categories: Style

Remediation Points: 50000

Sometimes two consecutive 'if' statements can be consolidated by separating their conditions with a boolean short-circuit operator.

Example:

void bar() {
 if (x) { // original implementation
 if (y) {
 // do stuff
 }
 }
}

void bar() {
 if (x && y) { // optimized implementation
 // do stuff
 }
}

These nested if statements could be combined
Open

            if (id.endsWith("s")) {
                id = id.substring(0, id.length() - 1);
            }
Severity: Minor
Found in src/main/java/de/uniks/networkparser/ext/story/Cucumber.java by pmd

CollapsibleIfStatements

Since: PMD 3.1

Priority: Medium

Categories: Style

Remediation Points: 50000

Sometimes two consecutive 'if' statements can be consolidated by separating their conditions with a boolean short-circuit operator.

Example:

void bar() {
 if (x) { // original implementation
 if (y) {
 // do stuff
 }
 }
}

void bar() {
 if (x && y) { // optimized implementation
 // do stuff
 }
}

These nested if statements could be combined
Open

            if (otherChildren.size() != 1 || parentNode != otherChildren.first()) {
                return false;
            }
Severity: Minor
Found in src/main/java/de/uniks/networkparser/graph/Association.java by pmd

CollapsibleIfStatements

Since: PMD 3.1

Priority: Medium

Categories: Style

Remediation Points: 50000

Sometimes two consecutive 'if' statements can be consolidated by separating their conditions with a boolean short-circuit operator.

Example:

void bar() {
 if (x) { // original implementation
 if (y) {
 // do stuff
 }
 }
}

void bar() {
 if (x && y) { // optimized implementation
 // do stuff
 }
}

Ensure you override both equals() and hashCode()
Open

    public boolean equals(Object obj) {
Severity: Minor
Found in src/main/java/de/uniks/networkparser/graph/AssociationTypes.java by pmd

OverrideBothEqualsAndHashcode

Since: PMD 0.4

Priority: Medium

Categories: Style

Remediation Points: 50000

Override both public boolean Object.equals(Object other), and public int Object.hashCode(), or override neither. Even if you are inheriting a hashCode() from a parent class, consider implementing hashCode and explicitly delegating to your superclass.

Example:

public class Bar { // poor, missing a hashcode() method
 public boolean equals(Object o) {
 // do some comparison
 }
}

public class Baz { // poor, missing an equals() method
 public int hashCode() {
 // return some hash value
 }
}

public class Foo { // perfect, both methods provided
 public boolean equals(Object other) {
 // do some comparison
 }
 public int hashCode() {
 // return some hash value
 }
}

These nested if statements could be combined
Open

                if (assocB.getName().equals(other.getName())) {
                    /* Found Link ?? */
                    foundAssoc = true;
                    if (assocA.getClazz() == assoc.getClazz()) {
                        if (assocB.getClazz() == other.getClazz()) {
Severity: Minor
Found in src/main/java/de/uniks/networkparser/graph/GraphUtil.java by pmd

CollapsibleIfStatements

Since: PMD 3.1

Priority: Medium

Categories: Style

Remediation Points: 50000

Sometimes two consecutive 'if' statements can be consolidated by separating their conditions with a boolean short-circuit operator.

Example:

void bar() {
 if (x) { // original implementation
 if (y) {
 // do stuff
 }
 }
}

void bar() {
 if (x && y) { // optimized implementation
 // do stuff
 }
}
Severity
Category
Status
Source
Language