Sign upLogin

fujaba/NetworkParser

View on GitHub
Star

Showing 4,645 of 4,645 total issues

Avoid using a branching statement as the last in a loop.
Open

            break;
Severity: Minor
Found in src/main/java/de/uniks/networkparser/ext/story/CucumberStdRule.java by pmd

AvoidBranchingStatementAsLastInLoop

Since: PMD 5.0

Priority: Medium High

Categories: Style

Remediation Points: 50000

Using a branching statement as the last part of a loop may be a bug, and/or is confusing. Ensure that the usage is not a bug, or consider using another approach.

Example:

// unusual use of branching statement in a loop
for (int i = 0; i < 10; i++) {
 if (i*i <= 25) {
 continue;
 }
 break;
}

// this makes more sense...
for (int i = 0; i < 10; i++) {
 if (i*i > 25) {
 break;
 }
}

These nested if statements could be combined
Open

                            if (assoc.contains(item, true, false) == false) {
                                assoc.getOther().setParentNode(item);
                                return true;
                            }
Severity: Minor
Found in src/main/java/de/uniks/networkparser/graph/Clazz.java by pmd

CollapsibleIfStatements

Since: PMD 3.1

Priority: Medium

Categories: Style

Remediation Points: 50000

Sometimes two consecutive 'if' statements can be consolidated by separating their conditions with a boolean short-circuit operator.

Example:

void bar() {
 if (x) { // original implementation
 if (y) {
 // do stuff
 }
 }
}

void bar() {
 if (x && y) { // optimized implementation
 // do stuff
 }
}

These nested if statements could be combined
Open

      if ("size".equalsIgnoreCase(keyString)) {
        return this.size();
      }
Severity: Minor
Found in src/main/java/de/uniks/networkparser/list/AbstractArray.java by pmd

CollapsibleIfStatements

Since: PMD 3.1

Priority: Medium

Categories: Style

Remediation Points: 50000

Sometimes two consecutive 'if' statements can be consolidated by separating their conditions with a boolean short-circuit operator.

Example:

void bar() {
 if (x) { // original implementation
 if (y) {
 // do stuff
 }
 }
}

void bar() {
 if (x && y) { // optimized implementation
 // do stuff
 }
}

Ensure you override both equals() and hashCode()
Open

    public boolean equals(Object obj) {
Severity: Minor
Found in src/main/java/de/uniks/networkparser/list/SimpleKeyValueList.java by pmd

OverrideBothEqualsAndHashcode

Since: PMD 0.4

Priority: Medium

Categories: Style

Remediation Points: 50000

Override both public boolean Object.equals(Object other), and public int Object.hashCode(), or override neither. Even if you are inheriting a hashCode() from a parent class, consider implementing hashCode and explicitly delegating to your superclass.

Example:

public class Bar { // poor, missing a hashcode() method
 public boolean equals(Object o) {
 // do some comparison
 }
}

public class Baz { // poor, missing an equals() method
 public int hashCode() {
 // return some hash value
 }
}

public class Foo { // perfect, both methods provided
 public boolean equals(Object other) {
 // do some comparison
 }
 public int hashCode() {
 // return some hash value
 }
}

These nested if statements could be combined
Open

            if (code != null) {
                String codeString = code.toString();
                if (codeString != null && codeString.length() > 0) {
                    return code.toString();
                }
Severity: Minor
Found in src/main/java/de/uniks/networkparser/parser/TemplateResultFile.java by pmd

CollapsibleIfStatements

Since: PMD 3.1

Priority: Medium

Categories: Style

Remediation Points: 50000

Sometimes two consecutive 'if' statements can be consolidated by separating their conditions with a boolean short-circuit operator.

Example:

void bar() {
 if (x) { // original implementation
 if (y) {
 // do stuff
 }
 }
}

void bar() {
 if (x && y) { // optimized implementation
 // do stuff
 }
}

These nested if statements could be combined
Open

                    if (condition.update(match)) {
                        break;
                    }
Severity: Minor
Found in src/main/java/de/uniks/networkparser/parser/differ/MemberDiffer.java by pmd

CollapsibleIfStatements

Since: PMD 3.1

Priority: Medium

Categories: Style

Remediation Points: 50000

Sometimes two consecutive 'if' statements can be consolidated by separating their conditions with a boolean short-circuit operator.

Example:

void bar() {
 if (x) { // original implementation
 if (y) {
 // do stuff
 }
 }
}

void bar() {
 if (x && y) { // optimized implementation
 // do stuff
 }
}

These nested if statements could be combined
Open

                if (this.players.remove(item)) {
                    item.withGame(null);
                }
Severity: Minor
Found in src/test/java/de/uniks/ludo/model/Ludo.java by pmd

CollapsibleIfStatements

Since: PMD 3.1

Priority: Medium

Categories: Style

Remediation Points: 50000

Sometimes two consecutive 'if' statements can be consolidated by separating their conditions with a boolean short-circuit operator.

Example:

void bar() {
 if (x) { // original implementation
 if (y) {
 // do stuff
 }
 }
}

void bar() {
 if (x && y) { // optimized implementation
 // do stuff
 }
}

These nested if statements could be combined
Open

                if (this.meeple.remove(item)) {
                    item.withPlayer(null);
                }
Severity: Minor
Found in src/test/java/de/uniks/ludo/model/Player.java by pmd

CollapsibleIfStatements

Since: PMD 3.1

Priority: Medium

Categories: Style

Remediation Points: 50000

Sometimes two consecutive 'if' statements can be consolidated by separating their conditions with a boolean short-circuit operator.

Example:

void bar() {
 if (x) { // original implementation
 if (y) {
 // do stuff
 }
 }
}

void bar() {
 if (x && y) { // optimized implementation
 // do stuff
 }
}

These nested if statements could be combined
Open

                if (this.assignments.remove(item)) {
                    item.withRoom(null);
                }
Severity: Minor
Found in src/test/java/org/sdmlib/test/examples/studyrightWithAssignments/model/Room.java by pmd

CollapsibleIfStatements

Since: PMD 3.1

Priority: Medium

Categories: Style

Remediation Points: 50000

Sometimes two consecutive 'if' statements can be consolidated by separating their conditions with a boolean short-circuit operator.

Example:

void bar() {
 if (x) { // original implementation
 if (y) {
 // do stuff
 }
 }
}

void bar() {
 if (x && y) { // optimized implementation
 // do stuff
 }
}

These nested if statements could be combined
Open

                if (this.students.remove(item)) {
                    item.withUniversity(null);
                }
Severity: Minor
Found in src/test/java/org/sdmlib/test/examples/studyrightWithAssignments/model/University.java by pmd

CollapsibleIfStatements

Since: PMD 3.1

Priority: Medium

Categories: Style

Remediation Points: 50000

Sometimes two consecutive 'if' statements can be consolidated by separating their conditions with a boolean short-circuit operator.

Example:

void bar() {
 if (x) { // original implementation
 if (y) {
 // do stuff
 }
 }
}

void bar() {
 if (x && y) { // optimized implementation
 // do stuff
 }
}

These nested if statements could be combined
Open

            if (ReflectionLoader.CHANGELISTENER.isAssignableFrom(listener.getClass())) {
                listeners.add(listener);
            }
Severity: Minor
Found in src/main/java/de/uniks/networkparser/ext/javafx/ModelListenerProperty.java by pmd

CollapsibleIfStatements

Since: PMD 3.1

Priority: Medium

Categories: Style

Remediation Points: 50000

Sometimes two consecutive 'if' statements can be consolidated by separating their conditions with a boolean short-circuit operator.

Example:

void bar() {
 if (x) { // original implementation
 if (y) {
 // do stuff
 }
 }
}

void bar() {
 if (x && y) { // optimized implementation
 // do stuff
 }
}

These nested if statements could be combined
Open

            if (ReflectionLoader.INVALIDATIONLISTENER.isAssignableFrom(listener.getClass())) {
                invalidationListeners.remove(listener);
            }
Severity: Minor
Found in src/main/java/de/uniks/networkparser/ext/javafx/ModelListenerProperty.java by pmd

CollapsibleIfStatements

Since: PMD 3.1

Priority: Medium

Categories: Style

Remediation Points: 50000

Sometimes two consecutive 'if' statements can be consolidated by separating their conditions with a boolean short-circuit operator.

Example:

void bar() {
 if (x) { // original implementation
 if (y) {
 // do stuff
 }
 }
}

void bar() {
 if (x && y) { // optimized implementation
 // do stuff
 }
}

These nested if statements could be combined
Open

                        if (primaryKey != null) {
                            statement.withCommand(SQLCommand.INSERT);
                            statement.withoutCondition(SQLStatement.ID);
                            statement.with(SQLStatement.ID, primaryKey);
                            values.addId(primaryKey);
Severity: Minor
Found in src/main/java/de/uniks/networkparser/ext/sql/SQLTokener.java by pmd

CollapsibleIfStatements

Since: PMD 3.1

Priority: Medium

Categories: Style

Remediation Points: 50000

Sometimes two consecutive 'if' statements can be consolidated by separating their conditions with a boolean short-circuit operator.

Example:

void bar() {
 if (x) { // original implementation
 if (y) {
 // do stuff
 }
 }
}

void bar() {
 if (x && y) { // optimized implementation
 // do stuff
 }
}

These nested if statements could be combined
Open

                        if (this.parentNode instanceof GraphModel) {
                            ((GraphModel) this.parentNode).with(assoc);
                        }
Severity: Minor
Found in src/main/java/de/uniks/networkparser/graph/GraphEntity.java by pmd

CollapsibleIfStatements

Since: PMD 3.1

Priority: Medium

Categories: Style

Remediation Points: 50000

Sometimes two consecutive 'if' statements can be consolidated by separating their conditions with a boolean short-circuit operator.

Example:

void bar() {
 if (x) { // original implementation
 if (y) {
 // do stuff
 }
 }
}

void bar() {
 if (x && y) { // optimized implementation
 // do stuff
 }
}

These nested if statements could be combined
Open

      if (indexOf(element, size) >= 0) {
        return REMOVED;
      }
Severity: Minor
Found in src/main/java/de/uniks/networkparser/list/AbstractArray.java by pmd

CollapsibleIfStatements

Since: PMD 3.1

Priority: Medium

Categories: Style

Remediation Points: 50000

Sometimes two consecutive 'if' statements can be consolidated by separating their conditions with a boolean short-circuit operator.

Example:

void bar() {
 if (x) { // original implementation
 if (y) {
 // do stuff
 }
 }
}

void bar() {
 if (x && y) { // optimized implementation
 // do stuff
 }
}

Avoid using a branching statement as the last in a loop.
Open

                    break;
Severity: Minor
Found in src/main/java/de/uniks/networkparser/parser/ParserEntity.java by pmd

AvoidBranchingStatementAsLastInLoop

Since: PMD 5.0

Priority: Medium High

Categories: Style

Remediation Points: 50000

Using a branching statement as the last part of a loop may be a bug, and/or is confusing. Ensure that the usage is not a bug, or consider using another approach.

Example:

// unusual use of branching statement in a loop
for (int i = 0; i < 10; i++) {
 if (i*i <= 25) {
 continue;
 }
 break;
}

// this makes more sense...
for (int i = 0; i < 10; i++) {
 if (i*i > 25) {
 break;
 }
}

These nested if statements could be combined
Open

                if (search.getReturnType().equals(method.getReturnType())) {
                    /* Check all Parameter */
                    ParameterSet searchParam = search.getParameters();
                    ParameterSet param = method.getParameters();
                    if (searchParam.size() == param.size()) {
Severity: Minor
Found in src/main/java/de/uniks/networkparser/parser/ParserEntity.java by pmd

CollapsibleIfStatements

Since: PMD 3.1

Priority: Medium

Categories: Style

Remediation Points: 50000

Sometimes two consecutive 'if' statements can be consolidated by separating their conditions with a boolean short-circuit operator.

Example:

void bar() {
 if (x) { // original implementation
 if (y) {
 // do stuff
 }
 }
}

void bar() {
 if (x && y) { // optimized implementation
 // do stuff
 }
}

These nested if statements could be combined
Open

                if (value.indexOf('.') > 0) {
                    value.set(item.getValue());
                    return true;
                }
Severity: Minor
Found in src/main/java/de/uniks/networkparser/xml/HTMLGrammar.java by pmd

CollapsibleIfStatements

Since: PMD 3.1

Priority: Medium

Categories: Style

Remediation Points: 50000

Sometimes two consecutive 'if' statements can be consolidated by separating their conditions with a boolean short-circuit operator.

Example:

void bar() {
 if (x) { // original implementation
 if (y) {
 // do stuff
 }
 }
}

void bar() {
 if (x && y) { // optimized implementation
 // do stuff
 }
}

These nested if statements could be combined
Open

            if (value.equalsIgnoreCase(this.getTag())) {
                return this;
            }
Severity: Minor
Found in src/main/java/de/uniks/networkparser/xml/XMLEntity.java by pmd

CollapsibleIfStatements

Since: PMD 3.1

Priority: Medium

Categories: Style

Remediation Points: 50000

Sometimes two consecutive 'if' statements can be consolidated by separating their conditions with a boolean short-circuit operator.

Example:

void bar() {
 if (x) { // original implementation
 if (y) {
 // do stuff
 }
 }
}

void bar() {
 if (x && y) { // optimized implementation
 // do stuff
 }
}

These nested if statements could be combined
Open

                if (this.item.remove(item)) {
                    item.setParent(null);
                    firePropertyChange(PROPERTY_ITEM, item, null);
                }
Severity: Minor
Found in src/test/java/de/uniks/networkparser/test/model/GroupAccount.java by pmd

CollapsibleIfStatements

Since: PMD 3.1

Priority: Medium

Categories: Style

Remediation Points: 50000

Sometimes two consecutive 'if' statements can be consolidated by separating their conditions with a boolean short-circuit operator.

Example:

void bar() {
 if (x) { // original implementation
 if (y) {
 // do stuff
 }
 }
}

void bar() {
 if (x && y) { // optimized implementation
 // do stuff
 }
}
Severity
Category
Status
Source
Language