Sign upLogin

fujaba/NetworkParser

View on GitHub
Star
src/main/java/de/uniks/networkparser/MapEntity.java

Summary

Maintainability
C
1 day
Test Coverage

MapEntity has 37 methods (exceeds 20 allowed). Consider refactoring.
Open

public class MapEntity extends AbstractList<Object> {
    protected Filter filter;
    protected int deep;
    protected Object target;
    protected MapEntityStack stack;
Severity: Minor
Found in src/main/java/de/uniks/networkparser/MapEntity.java - About 4 hrs to fix

    File MapEntity.java has 297 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    package de.uniks.networkparser;

import java.util.Iterator;

import de.uniks.networkparser.buffer.CharacterBuffer;
    Severity: Minor
    Found in src/main/java/de/uniks/networkparser/MapEntity.java - About 3 hrs to fix

      Method convertProperty has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

          public Entity convertProperty(CharacterBuffer property, BaseItem parent) {
        BaseItem child = parent;
        if (property == null) {
            return null;
        }
      Severity: Minor
      Found in src/main/java/de/uniks/networkparser/MapEntity.java - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method convertProperty has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public Entity convertProperty(CharacterBuffer property, BaseItem parent) {
        BaseItem child = parent;
        if (property == null) {
            return null;
        }
      Severity: Minor
      Found in src/main/java/de/uniks/networkparser/MapEntity.java - About 1 hr to fix

        Method writeBasicValue has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            public Entity writeBasicValue(SendableEntityCreator creator, Entity entity, BaseItem parent, String className,
            String id) {
        if ((mapFlag & IdMap.FLAG_ID) == 0) {
            if (creator instanceof SendableEntityCreatorTag) {
                className = ((SendableEntityCreatorTag) creator).getTag();
        Severity: Minor
        Found in src/main/java/de/uniks/networkparser/MapEntity.java - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method writeBasicValue has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public Entity writeBasicValue(SendableEntityCreator creator, Entity entity, BaseItem parent, String className,
            String id) {
        Severity: Minor
        Found in src/main/java/de/uniks/networkparser/MapEntity.java - About 35 mins to fix

          These nested if statements could be combined
          Open

                      if (className != null && className.startsWith("de.uniks.networkparser.ext.petaf")) {
                className = className.substring(className.lastIndexOf('.') + 1);
            }
          Severity: Minor
          Found in src/main/java/de/uniks/networkparser/MapEntity.java by pmd

          CollapsibleIfStatements

          Since: PMD 3.1

          Priority: Medium

          Categories: Style

          Remediation Points: 50000

          Sometimes two consecutive 'if' statements can be consolidated by separating their conditions with a boolean short-circuit operator.

          Example:

          void bar() {
 if (x) { // original implementation
 if (y) {
 // do stuff
 }
 }
}

void bar() {
 if (x && y) { // optimized implementation
 // do stuff
 }
}

          There are no issues that match your filters.

          Category
          Status