Method writeBasicValue has a Cognitive Complexity of 57 (exceeds 5 allowed). Consider refactoring. Open
@Override
public Entity writeBasicValue(Entity entity, String className, String id, String type, IdMap map) {
if (entity == null || map == null) {
return null;
}- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method writeBasicValue has 63 lines of code (exceeds 25 allowed). Consider refactoring. Open
@Override
public Entity writeBasicValue(Entity entity, String className, String id, String type, IdMap map) {
if (entity == null || map == null) {
return null;
}Method getCreator has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring. Open
@Override
public SendableEntityCreator getCreator(String type, Object item, MapEntity entity, String className) {
if (item == null) {
return null;
}- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method getCreator has 33 lines of code (exceeds 25 allowed). Consider refactoring. Open
@Override
public SendableEntityCreator getCreator(String type, Object item, MapEntity entity, String className) {
if (item == null) {
return null;
}Avoid deeply nested control flow statements. Open
if (id.length() > 0) {
ts = id.substring(1);
}Avoid deeply nested control flow statements. Open
if (EntityUtil.isNumeric(ts)) {
entity.put("." + IdMap.TIMESTAMP, ts);
}Method writeBasicValue has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
public Entity writeBasicValue(Entity entity, String className, String id, String type, IdMap map) {Method writeValue has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
public boolean writeValue(BaseItem parent, String property, Object value, MapEntity map, Tokener tokener) {Method getProperties has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
@Override
public BaseItem getProperties(Entity item, MapEntity map, boolean isId) {
if (item == null) {
return null;
}- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return statements within this method. Open
return getSuperCreator(map, entity.isSearchForSuperClass(), item);Avoid too many return statements within this method. Open
return getSuperCreator(map, entity.isSearchForSuperClass(), clazzName);Avoid too many return statements within this method. Open
return null;Avoid too many return statements within this method. Open
return creator;These nested if statements could be combined Open
if (map.getTimeStamp() == 0) {
String ts = null;
if (id.length() > 0) {
ts = id.substring(1);
}- Read upRead up
- Exclude checks
CollapsibleIfStatements
Since: PMD 3.1
Priority: Medium
Categories: Style
Remediation Points: 50000
Sometimes two consecutive 'if' statements can be consolidated by separating their conditions with a boolean short-circuit operator.
Example:
void bar() {
if (x) { // original implementation
if (y) {
// do stuff
}
}
}
void bar() {
if (x && y) { // optimized implementation
// do stuff
}
}These nested if statements could be combined Open
if (map.getTimeStamp() == 0) {
String ts = null;
if (id.length() > 0) {
ts = id.substring(1);
}- Read upRead up
- Exclude checks
CollapsibleIfStatements
Since: PMD 3.1
Priority: Medium
Categories: Style
Remediation Points: 50000
Sometimes two consecutive 'if' statements can be consolidated by separating their conditions with a boolean short-circuit operator.
Example:
void bar() {
if (x) { // original implementation
if (y) {
// do stuff
}
}
}
void bar() {
if (x && y) { // optimized implementation
// do stuff
}
}