Sign upLogin

fujaba/NetworkParser

View on GitHub
Star
src/main/java/de/uniks/networkparser/converter/YUMLConverter.java

Summary

Maintainability
C
1 day
Test Coverage

Method parse has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

    public boolean parse(String type, GraphEntity item, StringBuilder sb, SimpleList<GraphMember> visited,
            boolean shortName) {
        if (item == null) {
            return false;
        }
Severity: Minor
Found in src/main/java/de/uniks/networkparser/converter/YUMLConverter.java - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method parse has 52 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public boolean parse(String type, GraphEntity item, StringBuilder sb, SimpleList<GraphMember> visited,
            boolean shortName) {
        if (item == null) {
            return false;
        }
Severity: Major
Found in src/main/java/de/uniks/networkparser/converter/YUMLConverter.java - About 2 hrs to fix

    Method parseEntityValues has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        public String parseEntityValues(GraphEntity entity, String type, boolean shortName) {
        StringBuilder sb = new StringBuilder();
        GraphSimpleSet children = GraphUtil.getChildren(entity);
        if (children == null) {
            return null;
    Severity: Minor
    Found in src/main/java/de/uniks/networkparser/converter/YUMLConverter.java - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method parseEntityValues has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public String parseEntityValues(GraphEntity entity, String type, boolean shortName) {
        StringBuilder sb = new StringBuilder();
        GraphSimpleSet children = GraphUtil.getChildren(entity);
        if (children == null) {
            return null;
    Severity: Minor
    Found in src/main/java/de/uniks/networkparser/converter/YUMLConverter.java - About 1 hr to fix

      Method parse has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public boolean parse(String type, GraphEntity item, StringBuilder sb, SimpleList<GraphMember> visited,
            boolean shortName) {
      Severity: Minor
      Found in src/main/java/de/uniks/networkparser/converter/YUMLConverter.java - About 35 mins to fix

        Method parse has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public void parse(String type, GraphMember item, StringBuilder sb, SimpleList<GraphMember> visited,
            boolean shortName) {
        Severity: Minor
        Found in src/main/java/de/uniks/networkparser/converter/YUMLConverter.java - About 35 mins to fix

          Method parseEntity has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              public String parseEntity(GraphEntity entity, SimpleList<GraphMember> visited, String type, boolean shortName) {
        if (entity instanceof Clazz == false) {
            return "";
        }
        Clazz clazzEntity = (Clazz) entity;
          Severity: Minor
          Found in src/main/java/de/uniks/networkparser/converter/YUMLConverter.java - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method convert has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              public String convert(GraphModel root, boolean removePackage) {
        String type = GraphTokener.CLASSDIAGRAM;
        if (root instanceof GraphList) {
            type = ((GraphList) root).getType();
        }
          Severity: Minor
          Found in src/main/java/de/uniks/networkparser/converter/YUMLConverter.java - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          These nested if statements could be combined
          Open

                          if (GraphUtil.containsClazzAssociation(visited, element, other)) {
                    continue;
                }
          Severity: Minor
          Found in src/main/java/de/uniks/networkparser/converter/YUMLConverter.java by pmd

          CollapsibleIfStatements

          Since: PMD 3.1

          Priority: Medium

          Categories: Style

          Remediation Points: 50000

          Sometimes two consecutive 'if' statements can be consolidated by separating their conditions with a boolean short-circuit operator.

          Example:

          void bar() {
 if (x) { // original implementation
 if (y) {
 // do stuff
 }
 }
}

void bar() {
 if (x && y) { // optimized implementation
 // do stuff
 }
}

          There are no issues that match your filters.

          Category
          Status