Method getClassModelFromEPackage has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring. Open
public static final ClassModel getClassModelFromEPackage(Object epackage, String packageName, boolean withImpl) {
/* get class model from epackage */
ClassModel model = new ClassModel(packageName);
if (epackage == null || ReflectionLoader.EPACKAGE == null) {
return model;- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method getClassModelFromEPackage has 56 lines of code (exceeds 25 allowed). Consider refactoring. Open
public static final ClassModel getClassModelFromEPackage(Object epackage, String packageName, boolean withImpl) {
/* get class model from epackage */
ClassModel model = new ClassModel(packageName);
if (epackage == null || ReflectionLoader.EPACKAGE == null) {
return model;Method getEClasses has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
public static final List<EMFParser> getEClasses(Object eref) {
if (eref instanceof EMFParser) {
return getEClasses(((EMFParser) eref).getValue());
}
SimpleList<EMFParser> items = new SimpleList<EMFParser>();- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method addAttributes has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
public static final void addAttributes(EMFParser eclass, Clazz sdmClass) {
List<Object> callList = getEAttributes(eclass);
if (callList != null) {
for (Object item : callList) {
if (item != null) {- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method getESuperTypes has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
public static final SimpleList<EMFParser> getESuperTypes(Object eref) {
if (eref instanceof EMFParser) {
return getESuperTypes(((EMFParser) eref).getValue());
}
SimpleList<EMFParser> list = new SimpleList<EMFParser>();- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Ensure you override both equals() and hashCode() Open
public boolean equals(Object obj) {- Read upRead up
- Exclude checks
OverrideBothEqualsAndHashcode
Since: PMD 0.4
Priority: Medium
Categories: Style
Remediation Points: 50000
Override both public boolean Object.equals(Object other), and public int Object.hashCode(), or override neither. Even if you are inheriting a hashCode() from a parent class, consider implementing hashCode and explicitly delegating to your superclass.
Example:
public class Bar { // poor, missing a hashcode() method
public boolean equals(Object o) {
// do some comparison
}
}
public class Baz { // poor, missing an equals() method
public int hashCode() {
// return some hash value
}
}
public class Foo { // perfect, both methods provided
public boolean equals(Object other) {
// do some comparison
}
public int hashCode() {
// return some hash value
}
}