Method validator has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring. Open
public boolean validator(Entity original, Entity newLanguage, String prefix, boolean addNewLanguage) {
if (original == null || newLanguage == null) {
return false;
}
boolean result = true;- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method validator has 35 lines of code (exceeds 25 allowed). Consider refactoring. Open
public boolean validator(Entity original, Entity newLanguage, String prefix, boolean addNewLanguage) {
if (original == null || newLanguage == null) {
return false;
}
boolean result = true;Method transform has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
private CharacterBuffer transform(CharacterBuffer builder, BaseItem node, String prefix) {
if (builder == null || node == null || node instanceof Entity == false) {
return builder;
}
Entity entity = (Entity) node;- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method validate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
public boolean validate(BaseItem sourceLanguage, BaseItem targetLanguage, String targetFileName,
boolean getMissedText) {
if (sourceLanguage == null || targetLanguage == null) {
return false;
}- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
These nested if statements could be combined Open
if (value instanceof Entity && newValue instanceof Entity) {
String tag;
if (prefix.length() > 0) {
tag = prefix + "." + fieldName;
} else {- Read upRead up
- Exclude checks
CollapsibleIfStatements
Since: PMD 3.1
Priority: Medium
Categories: Style
Remediation Points: 50000
Sometimes two consecutive 'if' statements can be consolidated by separating their conditions with a boolean short-circuit operator.
Example:
void bar() {
if (x) { // original implementation
if (y) {
// do stuff
}
}
}
void bar() {
if (x && y) { // optimized implementation
// do stuff
}
}