fujaba/NetworkParser

View on GitHub
src/main/java/de/uniks/networkparser/ext/http/LoginService.java

Summary

Maintainability
C
1 day
Test Coverage

Method validateUser has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

    public User validateUser(String... values) {
        if (values == null || values.length < 1) {
            return null;
        }
        if (this.users == null) {
Severity: Minor
Found in src/main/java/de/uniks/networkparser/ext/http/LoginService.java - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method update has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    @Override
    public boolean update(SimpleEvent value) {
        if (value == null || value.getSource() instanceof HTTPRequest == false) {
            return false;
        }
Severity: Minor
Found in src/main/java/de/uniks/networkparser/ext/http/LoginService.java - About 1 hr to fix

    Method update has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        @Override
        public boolean update(SimpleEvent value) {
            if (value == null || value.getSource() instanceof HTTPRequest == false) {
                return false;
            }
    Severity: Minor
    Found in src/main/java/de/uniks/networkparser/ext/http/LoginService.java - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method validateUser has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public User validateUser(String... values) {
            if (values == null || values.length < 1) {
                return null;
            }
            if (this.users == null) {
    Severity: Minor
    Found in src/main/java/de/uniks/networkparser/ext/http/LoginService.java - About 1 hr to fix

      Avoid too many return statements within this method.
      Open

                          return user;
      Severity: Major
      Found in src/main/java/de/uniks/networkparser/ext/http/LoginService.java - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                            return user;
        Severity: Major
        Found in src/main/java/de/uniks/networkparser/ext/http/LoginService.java - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  return null;
          Severity: Major
          Found in src/main/java/de/uniks/networkparser/ext/http/LoginService.java - About 30 mins to fix

            There are no issues that match your filters.

            Category
            Status