File DialogBox.java has 464 lines of code (exceeds 250 allowed). Consider refactoring. Open
package de.uniks.networkparser.ext.javafx;
import java.io.File;
import java.io.PrintStream;
/*DialogBox has 37 methods (exceeds 20 allowed). Consider refactoring. Open
public class DialogBox implements ObjectCondition {
protected static final int HEADER_HEIGHT = 28;
protected static final URL DIALOGS_CSS_URL = DialogBox.class.getResource("dialogs.css");
boolean alwaysOnTop;
boolean modal = true;Method showFileChooser has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring. Open
@SuppressWarnings("unchecked")
public static String showFileChooser(String art, String caption, String defaultValue, String typeName,
String extensions, Object... parent) {
Object parentObj = null;
if (parent != null && parent.length > 0) {- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method showFileChooser has 66 lines of code (exceeds 25 allowed). Consider refactoring. Open
@SuppressWarnings("unchecked")
public static String showFileChooser(String art, String caption, String defaultValue, String typeName,
String extensions, Object... parent) {
Object parentObj = null;
if (parent != null && parent.length > 0) {Method update has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring. Open
@Override
public boolean update(Object event) {
if (event == null) {
return false;
}- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method update has 46 lines of code (exceeds 25 allowed). Consider refactoring. Open
@Override
public boolean update(Object event) {
if (event == null) {
return false;
}Method createContent has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
public DialogBox createContent() {
if (Os.isReflectionTest()) {
return this;
}
root = ReflectionLoader.newInstance(ReflectionLoader.BORDERPANE);Method configScene has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
@SuppressWarnings("unchecked")
void configScene() {
if (stage == null) {
return;
}- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method showFileChooser has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
public static String showFileChooser(String art, String caption, String defaultValue, String typeName,
String extensions, Object... parent) {Method showFileSaveChooser has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
public static String showFileSaveChooser(String caption, String defaultValue, String typeName, String typeExtension,
Object... parent) {Method showQuestionCheck has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
public static boolean showQuestionCheck(Object parent, String title, String text, String... check) {
Button action = showQuestion(parent, title, text);
if (action == null) {
return false;
}- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return statements within this method. Open
return true;Avoid too many return statements within this method. Open
return null;Avoid too many return statements within this method. Open
return false;These nested if statements could be combined Open
if (item.equalsIgnoreCase(action.getValue())) {
return true;
}- Read upRead up
- Exclude checks
CollapsibleIfStatements
Since: PMD 3.1
Priority: Medium
Categories: Style
Remediation Points: 50000
Sometimes two consecutive 'if' statements can be consolidated by separating their conditions with a boolean short-circuit operator.
Example:
void bar() {
if (x) { // original implementation
if (y) {
// do stuff
}
}
}
void bar() {
if (x && y) { // optimized implementation
// do stuff
}
}