src/main/java/de/uniks/networkparser/ext/javafx/GUIEvent.java
Method create has 67 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public static GUIEvent create(Object obj) {
GUIEvent event = new GUIEvent();
if (obj == null) {
return event;
}Method create has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring. Open
Open
public static GUIEvent create(Object obj) {
GUIEvent event = new GUIEvent();
if (obj == null) {
return event;
}- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method match has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
Open
public ObjectCondition match(Object other) {
if (other == null) {
return null;
}
if (other instanceof ObjectCondition) {- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return statements within this method. Open
Open
return event;Avoid too many return statements within this method. Open
Open
return event;These nested if statements could be combined Open
Open
if (this.getCode() == otherEvt.getCode()) {
return otherEvt.getListener();
}- Read upRead up
- Exclude checks
CollapsibleIfStatements
Since: PMD 3.1
Priority: Medium
Categories: Style
Remediation Points: 50000
Sometimes two consecutive 'if' statements can be consolidated by separating their conditions with a boolean short-circuit operator.
Example:
void bar() {
if (x) { // original implementation
if (y) {
// do stuff
}
}
}
void bar() {
if (x && y) { // optimized implementation
// do stuff
}
}