File JavaAdapter.java has 331 lines of code (exceeds 250 allowed). Consider refactoring. Open
package de.uniks.networkparser.ext.javafx;
import java.io.File;
import java.util.concurrent.CountDownLatch;
Method load has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring. Open
@Override
public boolean load(Object item) {
if (item instanceof String) {
ReflectionLoader.call(webEngine, "load", item);
return true;- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
JavaAdapter has 22 methods (exceeds 20 allowed). Consider refactoring. Open
public class JavaAdapter implements JavaViewAdapter, Runnable {
private SimpleKeyValueList<Object, String> callBack = new SimpleKeyValueList<Object, String>();
protected JavaBridge owner;
protected Object webView;
protected Object webEngine;Method load has 56 lines of code (exceeds 25 allowed). Consider refactoring. Open
@Override
public boolean load(Object item) {
if (item instanceof String) {
ReflectionLoader.call(webEngine, "load", item);
return true;Method getWebView has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
@Override
public Object getWebView() {
if (webView == null) {
if (ReflectionLoader.WEBVIEW != null && Os.isJavaFX()) {
if (Os.isFXThread()) {- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return statements within this method. Open
return true;Avoid too many return statements within this method. Open
return true;These nested if statements could be combined Open
if (logger != null) {
logger.error(this, "load", "FILE NOT FOUND");
}- Read upRead up
- Exclude checks
CollapsibleIfStatements
Since: PMD 3.1
Priority: Medium
Categories: Style
Remediation Points: 50000
Sometimes two consecutive 'if' statements can be consolidated by separating their conditions with a boolean short-circuit operator.
Example:
void bar() {
if (x) { // original implementation
if (y) {
// do stuff
}
}
}
void bar() {
if (x && y) { // optimized implementation
// do stuff
}
}These nested if statements could be combined Open
if (logger != null) {
logger.error(this, "showAlert", value);
}- Read upRead up
- Exclude checks
CollapsibleIfStatements
Since: PMD 3.1
Priority: Medium
Categories: Style
Remediation Points: 50000
Sometimes two consecutive 'if' statements can be consolidated by separating their conditions with a boolean short-circuit operator.
Example:
void bar() {
if (x) { // original implementation
if (y) {
// do stuff
}
}
}
void bar() {
if (x && y) { // optimized implementation
// do stuff
}
}These nested if statements could be combined Open
if (SUCCEEDED.equals("" + event.getNewValue())) {
/* FINISH */
this.loadFinish();
return true;
}- Read upRead up
- Exclude checks
CollapsibleIfStatements
Since: PMD 3.1
Priority: Medium
Categories: Style
Remediation Points: 50000
Sometimes two consecutive 'if' statements can be consolidated by separating their conditions with a boolean short-circuit operator.
Example:
void bar() {
if (x) { // original implementation
if (y) {
// do stuff
}
}
}
void bar() {
if (x && y) { // optimized implementation
// do stuff
}
}These nested if statements could be combined Open
if (child.has(HTMLEntity.KEY_SRC) == false) {
this._execute(child.getValue(), false);
}- Read upRead up
- Exclude checks
CollapsibleIfStatements
Since: PMD 3.1
Priority: Medium
Categories: Style
Remediation Points: 50000
Sometimes two consecutive 'if' statements can be consolidated by separating their conditions with a boolean short-circuit operator.
Example:
void bar() {
if (x) { // original implementation
if (y) {
// do stuff
}
}
}
void bar() {
if (x && y) { // optimized implementation
// do stuff
}
}These nested if statements could be combined Open
if (ReflectionLoader.WEBVIEW != null && Os.isJavaFX()) {
if (Os.isFXThread()) {
this.webView = ReflectionLoader.newInstance(ReflectionLoader.WEBVIEW);
this.webEngine = ReflectionLoader.call(this.webView, "getEngine");
ReflectionLoader.call(this.webView, "setMaxSize", double.class, Double.MAX_VALUE, double.class,- Read upRead up
- Exclude checks
CollapsibleIfStatements
Since: PMD 3.1
Priority: Medium
Categories: Style
Remediation Points: 50000
Sometimes two consecutive 'if' statements can be consolidated by separating their conditions with a boolean short-circuit operator.
Example:
void bar() {
if (x) { // original implementation
if (y) {
// do stuff
}
}
}
void bar() {
if (x && y) { // optimized implementation
// do stuff
}
}These nested if statements could be combined Open
if (Os.isFXThread()) {
this.webView = ReflectionLoader.newInstance(ReflectionLoader.WEBVIEW);
this.webEngine = ReflectionLoader.call(this.webView, "getEngine");
ReflectionLoader.call(this.webView, "setMaxSize", double.class, Double.MAX_VALUE, double.class,
Double.MAX_VALUE);- Read upRead up
- Exclude checks
CollapsibleIfStatements
Since: PMD 3.1
Priority: Medium
Categories: Style
Remediation Points: 50000
Sometimes two consecutive 'if' statements can be consolidated by separating their conditions with a boolean short-circuit operator.
Example:
void bar() {
if (x) { // original implementation
if (y) {
// do stuff
}
}
}
void bar() {
if (x && y) { // optimized implementation
// do stuff
}
}