fujaba/NetworkParser

View on GitHub
src/main/java/de/uniks/networkparser/ext/petaf/Message.java

Summary

Maintainability
C
1 day
Test Coverage

Message has 32 methods (exceeds 20 allowed). Consider refactoring.
Open

public class Message implements SendableEntityCreator, SendableEntityCreatorNoIndex {
    public static final String PROPERTY_HISTORYID = "id";
    public static final String PROPERTY_PREVIOUSCHANGE = "prevChange";
    public static final String PROPERTY_MSG = "msg";
    public static final String PROPERTY_RECEIVED = "received";
Severity: Minor
Found in src/main/java/de/uniks/networkparser/ext/petaf/Message.java - About 4 hrs to fix

    Method setValue has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        @Override
        public boolean setValue(Object entity, String attribute, Object value, String type) {
            if (attribute == null || entity instanceof Message == false) {
                return false;
            }
    Severity: Minor
    Found in src/main/java/de/uniks/networkparser/ext/petaf/Message.java - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method setValue has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        @Override
        public boolean setValue(Object entity, String attribute, Object value, String type) {
            if (attribute == null || entity instanceof Message == false) {
                return false;
            }
    Severity: Minor
    Found in src/main/java/de/uniks/networkparser/ext/petaf/Message.java - About 1 hr to fix

      Method getValue has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          @Override
          public Object getValue(Object entity, String attribute) {
              if (attribute == null || entity instanceof Message == false) {
                  return null;
              }
      Severity: Minor
      Found in src/main/java/de/uniks/networkparser/ext/petaf/Message.java - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

                  return msg.getReceived();
      Severity: Major
      Found in src/main/java/de/uniks/networkparser/ext/petaf/Message.java - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return msg.getType();
        Severity: Major
        Found in src/main/java/de/uniks/networkparser/ext/petaf/Message.java - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  return false;
          Severity: Major
          Found in src/main/java/de/uniks/networkparser/ext/petaf/Message.java - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                    return null;
            Severity: Major
            Found in src/main/java/de/uniks/networkparser/ext/petaf/Message.java - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return true;
              Severity: Major
              Found in src/main/java/de/uniks/networkparser/ext/petaf/Message.java - About 30 mins to fix

                There are no issues that match your filters.

                Category
                Status