fujaba/NetworkParser

View on GitHub
src/main/java/de/uniks/networkparser/ext/petaf/NodeProxy.java

Summary

Maintainability
D
2 days
Test Coverage

NodeProxy has 47 methods (exceeds 20 allowed). Consider refactoring.
Open

public abstract class NodeProxy extends SendableItem implements Comparable<NodeProxy>, SendableEntityCreatorNoIndex {
    public static final String TYPE_IN = "IN";
    public static final String TYPE_OUT = "OUT";
    public static final String TYPE_INOUT = "INOUT";

Severity: Minor
Found in src/main/java/de/uniks/networkparser/ext/petaf/NodeProxy.java - About 6 hrs to fix

    File NodeProxy.java has 340 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    package de.uniks.networkparser.ext.petaf;
    
    import de.uniks.networkparser.SendableItem;
    /*
    The MIT License
    Severity: Minor
    Found in src/main/java/de/uniks/networkparser/ext/petaf/NodeProxy.java - About 4 hrs to fix

      Method setValue has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          @Override
          public boolean setValue(Object element, String attrName, Object value, String type) {
              if (element instanceof NodeProxy == false) {
                  return false;
              }
      Severity: Minor
      Found in src/main/java/de/uniks/networkparser/ext/petaf/NodeProxy.java - About 1 hr to fix

        Method getValue has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            @Override
            public Object getValue(Object element, String attrName) {
                if (element instanceof NodeProxy == false) {
                    return null;
                }
        Severity: Minor
        Found in src/main/java/de/uniks/networkparser/ext/petaf/NodeProxy.java - About 1 hr to fix

          Method setValue has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              @Override
              public boolean setValue(Object element, String attrName, Object value, String type) {
                  if (element instanceof NodeProxy == false) {
                      return false;
                  }
          Severity: Minor
          Found in src/main/java/de/uniks/networkparser/ext/petaf/NodeProxy.java - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method getValue has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              @Override
              public Object getValue(Object element, String attrName) {
                  if (element instanceof NodeProxy == false) {
                      return null;
                  }
          Severity: Minor
          Found in src/main/java/de/uniks/networkparser/ext/petaf/NodeProxy.java - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method compareTo has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              public int compareTo(NodeProxy o) {
                  if (getKey() == null) {
                      if (o.getKey() == null) {
                          return 0;
                      }
          Severity: Minor
          Found in src/main/java/de/uniks/networkparser/ext/petaf/NodeProxy.java - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this method.
          Open

                      return nodeProxy.getKey();
          Severity: Major
          Found in src/main/java/de/uniks/networkparser/ext/petaf/NodeProxy.java - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                        return nodeProxy.getType();
            Severity: Major
            Found in src/main/java/de/uniks/networkparser/ext/petaf/NodeProxy.java - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return nodeProxy.isOnline();
              Severity: Major
              Found in src/main/java/de/uniks/networkparser/ext/petaf/NodeProxy.java - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                            return true;
                Severity: Major
                Found in src/main/java/de/uniks/networkparser/ext/petaf/NodeProxy.java - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                          return getKey().compareTo(o.getKey());
                  Severity: Major
                  Found in src/main/java/de/uniks/networkparser/ext/petaf/NodeProxy.java - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                return true;
                    Severity: Major
                    Found in src/main/java/de/uniks/networkparser/ext/petaf/NodeProxy.java - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                              return false;
                      Severity: Major
                      Found in src/main/java/de/uniks/networkparser/ext/petaf/NodeProxy.java - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                    return true;
                        Severity: Major
                        Found in src/main/java/de/uniks/networkparser/ext/petaf/NodeProxy.java - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                  return null;
                          Severity: Major
                          Found in src/main/java/de/uniks/networkparser/ext/petaf/NodeProxy.java - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                        return nodeProxy.getFilter();
                            Severity: Major
                            Found in src/main/java/de/uniks/networkparser/ext/petaf/NodeProxy.java - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Open

                                          return nodeProxy.getVersion();
                              Severity: Major
                              Found in src/main/java/de/uniks/networkparser/ext/petaf/NodeProxy.java - About 30 mins to fix

                                Avoid too many return statements within this method.
                                Open

                                            return true;
                                Severity: Major
                                Found in src/main/java/de/uniks/networkparser/ext/petaf/NodeProxy.java - About 30 mins to fix

                                  Avoid too many return statements within this method.
                                  Open

                                              return true;
                                  Severity: Major
                                  Found in src/main/java/de/uniks/networkparser/ext/petaf/NodeProxy.java - About 30 mins to fix

                                    Method isReconnecting has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                                    Open

                                        public boolean isReconnecting(SimpleList<Integer> seconds) {
                                            if (isOnline() || seconds.size() < 1) {
                                                return false;
                                            }
                                            if (lastSendCount >= seconds.size()) {
                                    Severity: Minor
                                    Found in src/main/java/de/uniks/networkparser/ext/petaf/NodeProxy.java - About 25 mins to fix

                                    Cognitive Complexity

                                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                    A method's cognitive complexity is based on a few simple rules:

                                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                    • Code is considered more complex for each "break in the linear flow of the code"
                                    • Code is considered more complex when "flow breaking structures are nested"

                                    Further reading

                                    There are no issues that match your filters.

                                    Category
                                    Status