fujaba/NetworkParser

View on GitHub
src/main/java/de/uniks/networkparser/ext/petaf/UpdateModel.java

Summary

Maintainability
C
7 hrs
Test Coverage

Method call has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

    @Override
    public Object call() {
        try {
            IdMap map = this.owner.getMap();
            if (map == null || this.entity == null) {
Severity: Minor
Found in src/main/java/de/uniks/networkparser/ext/petaf/UpdateModel.java - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method call has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    @Override
    public Object call() {
        try {
            IdMap map = this.owner.getMap();
            if (map == null || this.entity == null) {
Severity: Minor
Found in src/main/java/de/uniks/networkparser/ext/petaf/UpdateModel.java - About 1 hr to fix

    Avoid deeply nested control flow statements.
    Open

                                if (newValue == null) {
                                    return value;
                                } else {
                                    /* Its Remove */
                                    return creator.setValue(element, property, newValue, SendableEntityCreator.REMOVE);
    Severity: Major
    Found in src/main/java/de/uniks/networkparser/ext/petaf/UpdateModel.java - About 45 mins to fix

      Avoid too many return statements within this method.
      Open

                  return creator.setValue(element, property, newValue, SendableEntityCreator.NEW);
      Severity: Major
      Found in src/main/java/de/uniks/networkparser/ext/petaf/UpdateModel.java - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                        return element;
        Severity: Major
        Found in src/main/java/de/uniks/networkparser/ext/petaf/UpdateModel.java - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  return false;
          Severity: Major
          Found in src/main/java/de/uniks/networkparser/ext/petaf/UpdateModel.java - About 30 mins to fix

            There are no issues that match your filters.

            Category
            Status