Sign upLogin

fujaba/NetworkParser

View on GitHub
Star
src/main/java/de/uniks/networkparser/ext/petaf/proxy/NodeProxyBroker.java

Summary

Maintainability
C
1 day
Test Coverage

NodeProxyBroker has 28 methods (exceeds 20 allowed). Consider refactoring.
Open

public class NodeProxyBroker extends NodeProxy {
    public static final String PROPERTY_SERVERURL = "url";
    public static final String PROPERTY_clientId = "clientId";
    private String sender;
    private String password;
Severity: Minor
Found in src/main/java/de/uniks/networkparser/ext/petaf/proxy/NodeProxyBroker.java - About 3 hrs to fix

    File NodeProxyBroker.java has 274 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    package de.uniks.networkparser.ext.petaf.proxy;

/*
The MIT License
    Severity: Minor
    Found in src/main/java/de/uniks/networkparser/ext/petaf/proxy/NodeProxyBroker.java - About 2 hrs to fix

      Method subscribe has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          public boolean subscribe(String topic) {
        if (session != null) {
            if (MessageSession.TYPE_AMQ.equals(format)) {
                RabbitMessage message;
                message = RabbitMessage.createChannelOpen(this, topic);
      Severity: Minor
      Found in src/main/java/de/uniks/networkparser/ext/petaf/proxy/NodeProxyBroker.java - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method close has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          public boolean close(boolean force) {
        /* @TRACE 113=< */
        if (session == null) {
            return true;
        }
      Severity: Minor
      Found in src/main/java/de/uniks/networkparser/ext/petaf/proxy/NodeProxyBroker.java - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method subscribe has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public boolean subscribe(String topic) {
        if (session != null) {
            if (MessageSession.TYPE_AMQ.equals(format)) {
                RabbitMessage message;
                message = RabbitMessage.createChannelOpen(this, topic);
      Severity: Minor
      Found in src/main/java/de/uniks/networkparser/ext/petaf/proxy/NodeProxyBroker.java - About 1 hr to fix

        Avoid too many return statements within this method.
        Open

                return false;
        Severity: Major
        Found in src/main/java/de/uniks/networkparser/ext/petaf/proxy/NodeProxyBroker.java - About 30 mins to fix

          Method connect has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              public boolean connect() {
        if (session == null) {
            session = new MessageSession();
        }
        if (session.isClose() == false) {
          Severity: Minor
          Found in src/main/java/de/uniks/networkparser/ext/petaf/proxy/NodeProxyBroker.java - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status