src/main/java/de/uniks/networkparser/graph/AssociationTypes.java
Method create has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public static AssociationTypes create(String value) {
if (ASSOCIATION.equals(value)) {
return ASSOCIATION;
}
if ("association".equalsIgnoreCase(value)) {Method create has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
Open
public static AssociationTypes create(String value) {
if (ASSOCIATION.equals(value)) {
return ASSOCIATION;
}
if ("association".equalsIgnoreCase(value)) {- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return statements within this method. Open
Open
return UNDIRECTIONAL;Avoid too many return statements within this method. Open
Open
return null;Avoid too many return statements within this method. Open
Open
return AGGREGATION;Avoid too many return statements within this method. Open
Open
return COMPOSITION;Avoid too many return statements within this method. Open
Open
return DEPENDENCY;Avoid too many return statements within this method. Open
Open
return IMPLEMENTS;Ensure you override both equals() and hashCode() Open
Open
public boolean equals(Object obj) {- Read upRead up
- Exclude checks
OverrideBothEqualsAndHashcode
Since: PMD 0.4
Priority: Medium
Categories: Style
Remediation Points: 50000
Override both public boolean Object.equals(Object other), and public int Object.hashCode(), or override neither. Even if you are inheriting a hashCode() from a parent class, consider implementing hashCode and explicitly delegating to your superclass.
Example:
public class Bar { // poor, missing a hashcode() method
public boolean equals(Object o) {
// do some comparison
}
}
public class Baz { // poor, missing an equals() method
public int hashCode() {
// return some hash value
}
}
public class Foo { // perfect, both methods provided
public boolean equals(Object other) {
// do some comparison
}
public int hashCode() {
// return some hash value
}
}