Sign upLogin

fujaba/NetworkParser

View on GitHub
Star
src/main/java/de/uniks/networkparser/logic/ForeachCondition.java

Summary

Maintainability
C
1 day
Test Coverage

Method update has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
Open

    @Override
    public boolean update(Object value) {
        if (expression != null && loop != null) {
            if (expression instanceof ParserCondition && value instanceof LocalisationInterface) {
                ParserCondition parser = (ParserCondition) expression;
Severity: Minor
Found in src/main/java/de/uniks/networkparser/logic/ForeachCondition.java - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method update has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    @Override
    public boolean update(Object value) {
        if (expression != null && loop != null) {
            if (expression instanceof ParserCondition && value instanceof LocalisationInterface) {
                ParserCondition parser = (ParserCondition) expression;
Severity: Minor
Found in src/main/java/de/uniks/networkparser/logic/ForeachCondition.java - About 1 hr to fix

    Avoid deeply nested control flow statements.
    Open

                            if (this.preLoopCondition != null && pos > 0) {
                            this.preLoopCondition.update(value);
                        }
    Severity: Major
    Found in src/main/java/de/uniks/networkparser/logic/ForeachCondition.java - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                              if (notify) {
                            ((LocalisationInterface) value).put(NOTIFY, this);
                        }
      Severity: Major
      Found in src/main/java/de/uniks/networkparser/logic/ForeachCondition.java - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                if (notify) {
                            ((LocalisationInterface) value).put(NOTIFY, null);
                        }
        Severity: Major
        Found in src/main/java/de/uniks/networkparser/logic/ForeachCondition.java - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                                  if (this.postLoopCondition != null && pos > 0) {
                            this.postLoopCondition.update(value);
                        }
          Severity: Major
          Found in src/main/java/de/uniks/networkparser/logic/ForeachCondition.java - About 45 mins to fix

            These nested if statements could be combined
            Open

                        if (expression instanceof ParserCondition && value instanceof LocalisationInterface) {
                ParserCondition parser = (ParserCondition) expression;
                Object object = parser.getValue((LocalisationInterface) value);
                LocalisationInterface variablen = (LocalisationInterface) value;
                if (object instanceof Collection<?>) {
            Severity: Minor
            Found in src/main/java/de/uniks/networkparser/logic/ForeachCondition.java by pmd

            CollapsibleIfStatements

            Since: PMD 3.1

            Priority: Medium

            Categories: Style

            Remediation Points: 50000

            Sometimes two consecutive 'if' statements can be consolidated by separating their conditions with a boolean short-circuit operator.

            Example:

            void bar() {
 if (x) { // original implementation
 if (y) {
 // do stuff
 }
 }
}

void bar() {
 if (x && y) { // optimized implementation
 // do stuff
 }
}

            There are no issues that match your filters.

            Category
            Status