fujaba/NetworkParser

View on GitHub
src/main/java/de/uniks/networkparser/logic/IfCondition.java

Summary

Maintainability
D
1 day
Test Coverage

Method update has a Cognitive Complexity of 46 (exceeds 5 allowed). Consider refactoring.
Open

    @Override
    public boolean update(Object evt) {
        if (expression != null && expression.update(evt)) {
            if (trueCondition != null) {
                if (this.notifyBuffer == null || evt instanceof LocalisationInterface == false) {
Severity: Minor
Found in src/main/java/de/uniks/networkparser/logic/IfCondition.java - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method update has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    @Override
    public boolean update(Object evt) {
        if (expression != null && expression.update(evt)) {
            if (trueCondition != null) {
                if (this.notifyBuffer == null || evt instanceof LocalisationInterface == false) {
Severity: Minor
Found in src/main/java/de/uniks/networkparser/logic/IfCondition.java - About 1 hr to fix

    Method create has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        @Override
        public void create(CharacterBuffer buffer, TemplateParser parser, LocalisationInterface customTemplate) {
            if(buffer == null) {
                return;
            }
    Severity: Minor
    Found in src/main/java/de/uniks/networkparser/logic/IfCondition.java - About 1 hr to fix

      Method create has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          @Override
          public void create(CharacterBuffer buffer, TemplateParser parser, LocalisationInterface customTemplate) {
              if(buffer == null) {
                  return;
              }
      Severity: Minor
      Found in src/main/java/de/uniks/networkparser/logic/IfCondition.java - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid deeply nested control flow statements.
      Open

                              if (oc != null) {
                                  oc.update(notifyBuffer);
                              }
      Severity: Major
      Found in src/main/java/de/uniks/networkparser/logic/IfCondition.java - About 45 mins to fix

        Avoid too many return statements within this method.
        Open

                return false;
        Severity: Major
        Found in src/main/java/de/uniks/networkparser/logic/IfCondition.java - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                      return true;
          Severity: Major
          Found in src/main/java/de/uniks/networkparser/logic/IfCondition.java - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                    return false;
            Severity: Major
            Found in src/main/java/de/uniks/networkparser/logic/IfCondition.java - About 30 mins to fix

              There are no issues that match your filters.

              Category
              Status