Method add has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring. Open
public boolean add(Object... values) {
if (values == null || values.length < 1) {
return false;
}
if (values.length == 1 && this.list == null) {- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method add has 45 lines of code (exceeds 25 allowed). Consider refactoring. Open
public boolean add(Object... values) {
if (values == null || values.length < 1) {
return false;
}
if (values.length == 1 && this.list == null) {Method updatePCE has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
public boolean updatePCE(PropertyChangeEvent evt) {
if (list instanceof PropertyChangeListener) {
((PropertyChangeListener) list).propertyChange(evt);
return true;
} else if (list instanceof ObjectCondition) {- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return statements within this method. Open
return list.add(values);Method updateSet has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
public boolean updateSet(Object evt) {
Set<ObjectCondition> list = getList();
boolean result = true;
for (ObjectCondition item : list) {
if (item.update(evt) == false) {- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
These nested if statements could be combined Open
if (chain) {
return false;
}- Read upRead up
- Exclude checks
CollapsibleIfStatements
Since: PMD 3.1
Priority: Medium
Categories: Style
Remediation Points: 50000
Sometimes two consecutive 'if' statements can be consolidated by separating their conditions with a boolean short-circuit operator.
Example:
void bar() {
if (x) { // original implementation
if (y) {
// do stuff
}
}
}
void bar() {
if (x && y) { // optimized implementation
// do stuff
}
}These nested if statements could be combined Open
if (values[0] instanceof ChainCondition == false) {
if (values[0] instanceof PropertyChangeListener || values[0] instanceof ObjectCondition) {
this.list = values[0];
}
return true;- Read upRead up
- Exclude checks
CollapsibleIfStatements
Since: PMD 3.1
Priority: Medium
Categories: Style
Remediation Points: 50000
Sometimes two consecutive 'if' statements can be consolidated by separating their conditions with a boolean short-circuit operator.
Example:
void bar() {
if (x) { // original implementation
if (y) {
// do stuff
}
}
}
void bar() {
if (x && y) { // optimized implementation
// do stuff
}
}