fujaba/NetworkParser

View on GitHub
src/main/java/de/uniks/networkparser/parser/differ/AddCondition.java

Summary

Maintainability
C
1 day
Test Coverage

Method calculateModelDiffs has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    @Override
    protected boolean calculateModelDiffs(GraphModel model, GraphMatcher matches, Match match) {
        if (match == null || matches == null) {
            return false;
        }
Severity: Minor
Found in src/main/java/de/uniks/networkparser/parser/differ/AddCondition.java - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method calculateFileDiffs has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    @Override
    protected boolean calculateFileDiffs(GraphModel model, GraphMatcher matches, Match match) {
        if (match == null || matches == null) {
            return false;
        }

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method calculateFileDiffs has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    @Override
    protected boolean calculateFileDiffs(GraphModel model, GraphMatcher matches, Match match) {
        if (match == null || matches == null) {
            return false;
        }

    Method calculateModelDiffs has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        @Override
        protected boolean calculateModelDiffs(GraphModel model, GraphMatcher matches, Match match) {
            if (match == null || matches == null) {
                return false;
            }

      Avoid too many return statements within this method.
      Open

              return true;
      Severity: Major
      Found in src/main/java/de/uniks/networkparser/parser/differ/AddCondition.java - About 30 mins to fix

        Method checkCondition has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            protected boolean checkCondition(GraphMatcher matches, Match match) {
                if (match == null || matches == null) {
                    return false;
                }
                GraphMember member = match.getMatch();
        Severity: Minor
        Found in src/main/java/de/uniks/networkparser/parser/differ/AddCondition.java - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status