src/main/java/de/uniks/networkparser/parser/differ/MemberDiffer.java
Method executeCondition has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
Open
public static void executeCondition(String action, List<MatchCondition> memberConditions, Match match) {
if (memberConditions != null && action != null) {
for (int i = 0; i < memberConditions.size(); i++) {
MatchCondition condition = memberConditions.get(i);
if (condition != null && action.equals(condition.getAction())) {- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method diff has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
Open
public void diff(GraphMatcher matches, List<Match> memberMatches) {
for (Match match : memberMatches) {
if (match.isMetaMatch()) {
MemberDiffer.executeCondition(SendableEntityCreator.REMOVE, memberConditions, match);
} else {- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
These nested if statements could be combined Open
Open
if (condition.update(match)) {
break;
}- Read upRead up
- Exclude checks
CollapsibleIfStatements
Since: PMD 3.1
Priority: Medium
Categories: Style
Remediation Points: 50000
Sometimes two consecutive 'if' statements can be consolidated by separating their conditions with a boolean short-circuit operator.
Example:
void bar() {
if (x) { // original implementation
if (y) {
// do stuff
}
}
}
void bar() {
if (x && y) { // optimized implementation
// do stuff
}
}