Method transformValue has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
private boolean transformValue(CharacterBuffer value, int deep, boolean isClassName) {
iterator.reset();
while (iterator.hasNext()) {
Entry<String, String> item = iterator.next();
if (isClassName && CLASSNAME.equals(item.getKey())) {- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method writeBasicValue has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
@Override
public Entity writeBasicValue(Entity entity, String className, String id, String type, IdMap map) {
CharacterBuffer value = new CharacterBuffer().with(className);
if (transformValue(value, 0, true) && entity != null) {
String prop = value.toString();- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method writeValue has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
public boolean writeValue(BaseItem parent, String property, Object value, MapEntity map, Tokener tokener) {Method writeBasicValue has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
public Entity writeBasicValue(Entity entity, String className, String id, String type, IdMap map) {Method writeValue has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
@Override
public boolean writeValue(BaseItem parent, String property, Object value, MapEntity map, Tokener tokener) {
if (parent instanceof EntityList && tokener.isChild(value)) {
((EntityList) parent).add(value);
} else if (parent instanceof Entity) {- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
These nested if statements could be combined Open
if (value.indexOf('.') > 0) {
value.set(item.getValue());
return true;
}- Read upRead up
- Exclude checks
CollapsibleIfStatements
Since: PMD 3.1
Priority: Medium
Categories: Style
Remediation Points: 50000
Sometimes two consecutive 'if' statements can be consolidated by separating their conditions with a boolean short-circuit operator.
Example:
void bar() {
if (x) { // original implementation
if (y) {
// do stuff
}
}
}
void bar() {
if (x && y) { // optimized implementation
// do stuff
}
}