Sign upLogin

fujaba/NetworkParser

View on GitHub
Star
src/test/java/de/uniks/ludo/model/Ludo.java

Summary

Maintainability
C
1 day
Test Coverage

Ludo has 28 methods (exceeds 20 allowed). Consider refactoring.
Open

public class Ludo {
    protected PropertyChangeSupport listeners = null;

    public boolean firePropertyChange(String propertyName, Object oldValue, Object newValue) {
        if (listeners != null) {
Severity: Minor
Found in src/test/java/de/uniks/ludo/model/Ludo.java - About 3 hrs to fix

    File Ludo.java has 261 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    package de.uniks.ludo.model;
import java.beans.PropertyChangeListener;
import java.beans.PropertyChangeSupport;
import de.uniks.ludo.model.Dice;
import de.uniks.ludo.model.util.FieldSet;
    Severity: Minor
    Found in src/test/java/de/uniks/ludo/model/Ludo.java - About 2 hrs to fix

      Method withField has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public Ludo withField(Object... values) {
        if (values == null) {
            return this;
        }
        for (Object item : values) {
      Severity: Minor
      Found in src/test/java/de/uniks/ludo/model/Ludo.java - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method withPlayers has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public Ludo withPlayers(Object... values) {
        if (values == null) {
            return this;
        }
        for (Object item : values) {
      Severity: Minor
      Found in src/test/java/de/uniks/ludo/model/Ludo.java - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method withoutField has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public Ludo withoutField(Field... value) {
        if(this.field == null) {
            return this;
        }
        for (Field item : value) {
      Severity: Minor
      Found in src/test/java/de/uniks/ludo/model/Ludo.java - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method setField has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public boolean setField(Field... values) {
        if (values == null) {
            return true;
        }
        boolean result=true;
      Severity: Minor
      Found in src/test/java/de/uniks/ludo/model/Ludo.java - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method setPlayers has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public boolean setPlayers(Player... values) {
        if (values == null) {
            return true;
        }
        boolean result=true;
      Severity: Minor
      Found in src/test/java/de/uniks/ludo/model/Ludo.java - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method withoutPlayers has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public Ludo withoutPlayers(Player... value) {
        if(this.players == null) {
            return this;
        }
        for (Player item : value) {
      Severity: Minor
      Found in src/test/java/de/uniks/ludo/model/Ludo.java - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      These nested if statements could be combined
      Open

                      if (this.players.remove(item)) {
                    item.withGame(null);
                }
      Severity: Minor
      Found in src/test/java/de/uniks/ludo/model/Ludo.java by pmd

      CollapsibleIfStatements

      Since: PMD 3.1

      Priority: Medium

      Categories: Style

      Remediation Points: 50000

      Sometimes two consecutive 'if' statements can be consolidated by separating their conditions with a boolean short-circuit operator.

      Example:

      void bar() {
 if (x) { // original implementation
 if (y) {
 // do stuff
 }
 }
}

void bar() {
 if (x && y) { // optimized implementation
 // do stuff
 }
}

      These nested if statements could be combined
      Open

                      if (this.field.remove(item)) {
                    item.withGame(null);
                }
      Severity: Minor
      Found in src/test/java/de/uniks/ludo/model/Ludo.java by pmd

      CollapsibleIfStatements

      Since: PMD 3.1

      Priority: Medium

      Categories: Style

      Remediation Points: 50000

      Sometimes two consecutive 'if' statements can be consolidated by separating their conditions with a boolean short-circuit operator.

      Example:

      void bar() {
 if (x) { // original implementation
 if (y) {
 // do stuff
 }
 }
}

void bar() {
 if (x && y) { // optimized implementation
 // do stuff
 }
}

      There are no issues that match your filters.

      Category
      Status