Sign upLogin

fujaba/NetworkParser

View on GitHub
Star
src/test/java/de/uniks/ludo/model/Player.java

Summary

Maintainability
D
2 days
Test Coverage

Player has 51 methods (exceeds 20 allowed). Consider refactoring.
Open

public class Player {
    protected PropertyChangeSupport listeners = null;

    public boolean firePropertyChange(String propertyName, Object oldValue, Object newValue) {
        if (listeners != null) {
Severity: Major
Found in src/test/java/de/uniks/ludo/model/Player.java - About 7 hrs to fix

    File Player.java has 453 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    package de.uniks.ludo.model;
import java.beans.PropertyChangeListener;
import java.beans.PropertyChangeSupport;
import de.uniks.ludo.model.util.HomeSet;
import java.util.Collection;
    Severity: Minor
    Found in src/test/java/de/uniks/ludo/model/Player.java - About 6 hrs to fix

      Method setHome has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public boolean setHome(Home... values) {
        if (values == null) {
            return true;
        }
        boolean result=true;
      Severity: Minor
      Found in src/test/java/de/uniks/ludo/model/Player.java - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method withoutHome has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public Player withoutHome(Home... value) {
        if(this.home == null) {
            return this;
        }
        for (Home item : value) {
      Severity: Minor
      Found in src/test/java/de/uniks/ludo/model/Player.java - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method setTarget has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public boolean setTarget(Target... values) {
        if (values == null) {
            return true;
        }
        boolean result=true;
      Severity: Minor
      Found in src/test/java/de/uniks/ludo/model/Player.java - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method withTarget has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public Player withTarget(Object... values) {
        if (values == null) {
            return this;
        }
        for (Object item : values) {
      Severity: Minor
      Found in src/test/java/de/uniks/ludo/model/Player.java - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method withoutTarget has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public Player withoutTarget(Target... value) {
        if(this.target == null) {
            return this;
        }
        for (Target item : value) {
      Severity: Minor
      Found in src/test/java/de/uniks/ludo/model/Player.java - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method withHome has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public Player withHome(Object... values) {
        if (values == null) {
            return this;
        }
        for (Object item : values) {
      Severity: Minor
      Found in src/test/java/de/uniks/ludo/model/Player.java - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method withoutMeeple has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public Player withoutMeeple(Meeple... value) {
        if(this.meeple == null) {
            return this;
        }
        for (Meeple item : value) {
      Severity: Minor
      Found in src/test/java/de/uniks/ludo/model/Player.java - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method setMeeple has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public boolean setMeeple(Meeple... values) {
        if (values == null) {
            return true;
        }
        boolean result=true;
      Severity: Minor
      Found in src/test/java/de/uniks/ludo/model/Player.java - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method withMeeple has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public Player withMeeple(Object... values) {
        if (values == null) {
            return this;
        }
        for (Object item : values) {
      Severity: Minor
      Found in src/test/java/de/uniks/ludo/model/Player.java - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      These nested if statements could be combined
      Open

                      if (this.target.remove(item)) {
                    item.withPlayer(null);
                }
      Severity: Minor
      Found in src/test/java/de/uniks/ludo/model/Player.java by pmd

      CollapsibleIfStatements

      Since: PMD 3.1

      Priority: Medium

      Categories: Style

      Remediation Points: 50000

      Sometimes two consecutive 'if' statements can be consolidated by separating their conditions with a boolean short-circuit operator.

      Example:

      void bar() {
 if (x) { // original implementation
 if (y) {
 // do stuff
 }
 }
}

void bar() {
 if (x && y) { // optimized implementation
 // do stuff
 }
}

      These nested if statements could be combined
      Open

                      if (this.home.remove(item)) {
                    item.withPlayer(null);
                }
      Severity: Minor
      Found in src/test/java/de/uniks/ludo/model/Player.java by pmd

      CollapsibleIfStatements

      Since: PMD 3.1

      Priority: Medium

      Categories: Style

      Remediation Points: 50000

      Sometimes two consecutive 'if' statements can be consolidated by separating their conditions with a boolean short-circuit operator.

      Example:

      void bar() {
 if (x) { // original implementation
 if (y) {
 // do stuff
 }
 }
}

void bar() {
 if (x && y) { // optimized implementation
 // do stuff
 }
}

      These nested if statements could be combined
      Open

                      if (this.meeple.remove(item)) {
                    item.withPlayer(null);
                }
      Severity: Minor
      Found in src/test/java/de/uniks/ludo/model/Player.java by pmd

      CollapsibleIfStatements

      Since: PMD 3.1

      Priority: Medium

      Categories: Style

      Remediation Points: 50000

      Sometimes two consecutive 'if' statements can be consolidated by separating their conditions with a boolean short-circuit operator.

      Example:

      void bar() {
 if (x) { // original implementation
 if (y) {
 // do stuff
 }
 }
}

void bar() {
 if (x && y) { // optimized implementation
 // do stuff
 }
}

      There are no issues that match your filters.

      Category
      Status