Sign upLogin

fujaba/NetworkParser

View on GitHub
Star
src/test/java/de/uniks/ludo/model/util/LudoSet.java

Summary

Maintainability
F
3 days
Test Coverage

File LudoSet.java has 269 lines of code (exceeds 250 allowed). Consider refactoring.
Open

package de.uniks.ludo.model.util;
import de.uniks.networkparser.interfaces.SendableEntityCreator;
import de.uniks.ludo.model.Ludo;
import de.uniks.networkparser.list.SimpleSet;
import de.uniks.ludo.model.Dice;
Severity: Minor
Found in src/test/java/de/uniks/ludo/model/util/LudoSet.java - About 2 hrs to fix

    Method getPlayers has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

        public PlayerSet getPlayers(Player... filter) {
        PlayerSet result = new PlayerSet();
        if(listener != null) {
            result.withListener(listener);
            Ludo[] children = this.toArray(new Ludo[size()]);
    Severity: Minor
    Found in src/test/java/de/uniks/ludo/model/util/LudoSet.java - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method getCurrentPlayer has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

        public PlayerSet getCurrentPlayer(Player... filter) {
        PlayerSet result = new PlayerSet();
        if(listener != null) {
            result.withListener(listener);
            Ludo[] children = this.toArray(new Ludo[size()]);
    Severity: Minor
    Found in src/test/java/de/uniks/ludo/model/util/LudoSet.java - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method getWinner has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

        public PlayerSet getWinner(Player... filter) {
        PlayerSet result = new PlayerSet();
        if(listener != null) {
            result.withListener(listener);
            Ludo[] children = this.toArray(new Ludo[size()]);
    Severity: Minor
    Found in src/test/java/de/uniks/ludo/model/util/LudoSet.java - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method getDice has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

        public DiceSet getDice(Dice... filter) {
        DiceSet result = new DiceSet();
        if(listener != null) {
            result.withListener(listener);
            Ludo[] children = this.toArray(new Ludo[size()]);
    Severity: Minor
    Found in src/test/java/de/uniks/ludo/model/util/LudoSet.java - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method getField has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

        public FieldSet getField(Field... filter) {
        FieldSet result = new FieldSet();
        if(listener != null) {
            result.withListener(listener);
            Ludo[] children = this.toArray(new Ludo[size()]);
    Severity: Minor
    Found in src/test/java/de/uniks/ludo/model/util/LudoSet.java - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method setValue has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        @Override
    public boolean setValue(Object entity, String attribute, Object value, String type) {
        if(attribute == null || entity instanceof Ludo == false) {
            return false;
        }
    Severity: Minor
    Found in src/test/java/de/uniks/ludo/model/util/LudoSet.java - About 1 hr to fix

      Method getPlayers has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public PlayerSet getPlayers(Player... filter) {
        PlayerSet result = new PlayerSet();
        if(listener != null) {
            result.withListener(listener);
            Ludo[] children = this.toArray(new Ludo[size()]);
      Severity: Minor
      Found in src/test/java/de/uniks/ludo/model/util/LudoSet.java - About 1 hr to fix

        Method getField has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public FieldSet getField(Field... filter) {
        FieldSet result = new FieldSet();
        if(listener != null) {
            result.withListener(listener);
            Ludo[] children = this.toArray(new Ludo[size()]);
        Severity: Minor
        Found in src/test/java/de/uniks/ludo/model/util/LudoSet.java - About 1 hr to fix

          Method getCurrentPlayer has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public PlayerSet getCurrentPlayer(Player... filter) {
        PlayerSet result = new PlayerSet();
        if(listener != null) {
            result.withListener(listener);
            Ludo[] children = this.toArray(new Ludo[size()]);
          Severity: Minor
          Found in src/test/java/de/uniks/ludo/model/util/LudoSet.java - About 1 hr to fix

            Method getDice has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public DiceSet getDice(Dice... filter) {
        DiceSet result = new DiceSet();
        if(listener != null) {
            result.withListener(listener);
            Ludo[] children = this.toArray(new Ludo[size()]);
            Severity: Minor
            Found in src/test/java/de/uniks/ludo/model/util/LudoSet.java - About 1 hr to fix

              Method getWinner has 27 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public PlayerSet getWinner(Player... filter) {
        PlayerSet result = new PlayerSet();
        if(listener != null) {
            result.withListener(listener);
            Ludo[] children = this.toArray(new Ludo[size()]);
              Severity: Minor
              Found in src/test/java/de/uniks/ludo/model/util/LudoSet.java - About 1 hr to fix

                Method setValue has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                Open

                    @Override
    public boolean setValue(Object entity, String attribute, Object value, String type) {
        if(attribute == null || entity instanceof Ludo == false) {
            return false;
        }
                Severity: Minor
                Found in src/test/java/de/uniks/ludo/model/util/LudoSet.java - About 55 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method getValue has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    @Override
    public Object getValue(Object entity, String attribute) {
        if(attribute == null || entity instanceof Ludo == false) {
            return null;
        }
                Severity: Minor
                Found in src/test/java/de/uniks/ludo/model/util/LudoSet.java - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Avoid too many return statements within this method.
                Open

                            return true;
                Severity: Major
                Found in src/test/java/de/uniks/ludo/model/util/LudoSet.java - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                          return false;
                  Severity: Major
                  Found in src/test/java/de/uniks/ludo/model/util/LudoSet.java - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                return element.getPlayers();
                    Severity: Major
                    Found in src/test/java/de/uniks/ludo/model/util/LudoSet.java - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                              return null;
                      Severity: Major
                      Found in src/test/java/de/uniks/ludo/model/util/LudoSet.java - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                    return true;
                        Severity: Major
                        Found in src/test/java/de/uniks/ludo/model/util/LudoSet.java - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                      return element.getWinner();
                          Severity: Major
                          Found in src/test/java/de/uniks/ludo/model/util/LudoSet.java - About 30 mins to fix

                            There are no issues that match your filters.

                            Category
                            Status