Sign upLogin

fujaba/NetworkParser

View on GitHub
Star
src/test/java/de/uniks/ludo/model/util/MeepleSet.java

Summary

Maintainability
C
7 hrs
Test Coverage

Method getPlayer has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    public PlayerSet getPlayer(Player... filter) {
        PlayerSet result = new PlayerSet();
        if(listener != null) {
            result.withListener(listener);
            Meeple[] children = this.toArray(new Meeple[size()]);
Severity: Minor
Found in src/test/java/de/uniks/ludo/model/util/MeepleSet.java - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getField has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    public FieldSet getField(Field... filter) {
        FieldSet result = new FieldSet();
        if(listener != null) {
            result.withListener(listener);
            Meeple[] children = this.toArray(new Meeple[size()]);
Severity: Minor
Found in src/test/java/de/uniks/ludo/model/util/MeepleSet.java - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getPlayer has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public PlayerSet getPlayer(Player... filter) {
        PlayerSet result = new PlayerSet();
        if(listener != null) {
            result.withListener(listener);
            Meeple[] children = this.toArray(new Meeple[size()]);
Severity: Minor
Found in src/test/java/de/uniks/ludo/model/util/MeepleSet.java - About 1 hr to fix

    Method getField has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public FieldSet getField(Field... filter) {
        FieldSet result = new FieldSet();
        if(listener != null) {
            result.withListener(listener);
            Meeple[] children = this.toArray(new Meeple[size()]);
    Severity: Minor
    Found in src/test/java/de/uniks/ludo/model/util/MeepleSet.java - About 1 hr to fix

      Method setValue has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          @Override
    public boolean setValue(Object entity, String attribute, Object value, String type) {
        if(attribute == null || entity instanceof Meeple == false) {
            return false;
        }
      Severity: Minor
      Found in src/test/java/de/uniks/ludo/model/util/MeepleSet.java - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status