fujaba/NetworkParser

View on GitHub
src/test/java/de/uniks/ludo/model/util/TargetSet.java

Summary

Maintainability
F
3 days
Test Coverage

File TargetSet.java has 303 lines of code (exceeds 250 allowed). Consider refactoring.
Open

package de.uniks.ludo.model.util;
import de.uniks.networkparser.interfaces.SendableEntityCreator;
import de.uniks.ludo.model.Target;
import de.uniks.networkparser.list.SimpleSet;
import de.uniks.ludo.model.LastField;
Severity: Minor
Found in src/test/java/de/uniks/ludo/model/util/TargetSet.java - About 3 hrs to fix

    Method getGame has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

        public LudoSet getGame(Ludo... filter) {
            LudoSet result = new LudoSet();
            if(listener != null) {
                result.withListener(listener);
                Target[] children = this.toArray(new Target[size()]);
    Severity: Minor
    Found in src/test/java/de/uniks/ludo/model/util/TargetSet.java - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method getPrev has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

        public FieldSet getPrev(Field... filter) {
            FieldSet result = new FieldSet();
            if(listener != null) {
                result.withListener(listener);
                Target[] children = this.toArray(new Target[size()]);
    Severity: Minor
    Found in src/test/java/de/uniks/ludo/model/util/TargetSet.java - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method getNext has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

        public FieldSet getNext(Field... filter) {
            FieldSet result = new FieldSet();
            if(listener != null) {
                result.withListener(listener);
                Target[] children = this.toArray(new Target[size()]);
    Severity: Minor
    Found in src/test/java/de/uniks/ludo/model/util/TargetSet.java - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method getMeeple has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

        public MeepleSet getMeeple(Meeple... filter) {
            MeepleSet result = new MeepleSet();
            if(listener != null) {
                result.withListener(listener);
                Target[] children = this.toArray(new Target[size()]);
    Severity: Minor
    Found in src/test/java/de/uniks/ludo/model/util/TargetSet.java - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method getPlayer has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

        public PlayerSet getPlayer(Player... filter) {
            PlayerSet result = new PlayerSet();
            if(listener != null) {
                result.withListener(listener);
                Target[] children = this.toArray(new Target[size()]);
    Severity: Minor
    Found in src/test/java/de/uniks/ludo/model/util/TargetSet.java - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method getLastField has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

        public LastFieldSet getLastField(LastField... filter) {
            LastFieldSet result = new LastFieldSet();
            if(listener != null) {
                result.withListener(listener);
                Target[] children = this.toArray(new Target[size()]);
    Severity: Minor
    Found in src/test/java/de/uniks/ludo/model/util/TargetSet.java - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method setValue has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        @Override
        public boolean setValue(Object entity, String attribute, Object value, String type) {
            if(attribute == null || entity instanceof Target == false) {
                return false;
            }
    Severity: Minor
    Found in src/test/java/de/uniks/ludo/model/util/TargetSet.java - About 1 hr to fix

      Method getNext has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public FieldSet getNext(Field... filter) {
              FieldSet result = new FieldSet();
              if(listener != null) {
                  result.withListener(listener);
                  Target[] children = this.toArray(new Target[size()]);
      Severity: Minor
      Found in src/test/java/de/uniks/ludo/model/util/TargetSet.java - About 1 hr to fix

        Method getGame has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public LudoSet getGame(Ludo... filter) {
                LudoSet result = new LudoSet();
                if(listener != null) {
                    result.withListener(listener);
                    Target[] children = this.toArray(new Target[size()]);
        Severity: Minor
        Found in src/test/java/de/uniks/ludo/model/util/TargetSet.java - About 1 hr to fix

          Method getMeeple has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public MeepleSet getMeeple(Meeple... filter) {
                  MeepleSet result = new MeepleSet();
                  if(listener != null) {
                      result.withListener(listener);
                      Target[] children = this.toArray(new Target[size()]);
          Severity: Minor
          Found in src/test/java/de/uniks/ludo/model/util/TargetSet.java - About 1 hr to fix

            Method getPlayer has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public PlayerSet getPlayer(Player... filter) {
                    PlayerSet result = new PlayerSet();
                    if(listener != null) {
                        result.withListener(listener);
                        Target[] children = this.toArray(new Target[size()]);
            Severity: Minor
            Found in src/test/java/de/uniks/ludo/model/util/TargetSet.java - About 1 hr to fix

              Method getPrev has 27 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public FieldSet getPrev(Field... filter) {
                      FieldSet result = new FieldSet();
                      if(listener != null) {
                          result.withListener(listener);
                          Target[] children = this.toArray(new Target[size()]);
              Severity: Minor
              Found in src/test/java/de/uniks/ludo/model/util/TargetSet.java - About 1 hr to fix

                Method getLastField has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public LastFieldSet getLastField(LastField... filter) {
                        LastFieldSet result = new LastFieldSet();
                        if(listener != null) {
                            result.withListener(listener);
                            Target[] children = this.toArray(new Target[size()]);
                Severity: Minor
                Found in src/test/java/de/uniks/ludo/model/util/TargetSet.java - About 1 hr to fix

                  Method setValue has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                  Open

                      @Override
                      public boolean setValue(Object entity, String attribute, Object value, String type) {
                          if(attribute == null || entity instanceof Target == false) {
                              return false;
                          }
                  Severity: Minor
                  Found in src/test/java/de/uniks/ludo/model/util/TargetSet.java - About 55 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method getValue has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                      @Override
                      public Object getValue(Object entity, String attribute) {
                          if(attribute == null || entity instanceof Target == false) {
                              return null;
                          }
                  Severity: Minor
                  Found in src/test/java/de/uniks/ludo/model/util/TargetSet.java - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Avoid too many return statements within this method.
                  Open

                              return true;
                  Severity: Major
                  Found in src/test/java/de/uniks/ludo/model/util/TargetSet.java - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                return element.getGame();
                    Severity: Major
                    Found in src/test/java/de/uniks/ludo/model/util/TargetSet.java - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                  return true;
                      Severity: Major
                      Found in src/test/java/de/uniks/ludo/model/util/TargetSet.java - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                return false;
                        Severity: Major
                        Found in src/test/java/de/uniks/ludo/model/util/TargetSet.java - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                      return element.getMeeple();
                          Severity: Major
                          Found in src/test/java/de/uniks/ludo/model/util/TargetSet.java - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                    return null;
                            Severity: Major
                            Found in src/test/java/de/uniks/ludo/model/util/TargetSet.java - About 30 mins to fix

                              There are no issues that match your filters.

                              Category
                              Status