Sign upLogin

fujaba/NetworkParser

View on GitHub
Star
src/test/java/org/sdmlib/test/examples/studyrightWithAssignments/model/Assignment.java

Summary

Maintainability
A
1 hr
Test Coverage

Method withoutStudents has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public Assignment withoutStudents(Student... value) {
        if(this.students == null) {
            return this;
        }
        for (Student item : value) {
Severity: Minor
Found in src/test/java/org/sdmlib/test/examples/studyrightWithAssignments/model/Assignment.java - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method setStudents has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public boolean setStudents(Student... values) {
        if (values == null) {
            return true;
        }
        boolean result=true;
Severity: Minor
Found in src/test/java/org/sdmlib/test/examples/studyrightWithAssignments/model/Assignment.java - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method withStudents has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public Assignment withStudents(Object... values) {
        if (values == null) {
            return this;
        }
        for (Object item : values) {
Severity: Minor
Found in src/test/java/org/sdmlib/test/examples/studyrightWithAssignments/model/Assignment.java - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

These nested if statements could be combined
Open

                if (this.students.remove(item)) {
                    item.withoutDone(this);
                }
Severity: Minor
Found in src/test/java/org/sdmlib/test/examples/studyrightWithAssignments/model/Assignment.java by pmd

CollapsibleIfStatements

Since: PMD 3.1

Priority: Medium

Categories: Style

Remediation Points: 50000

Sometimes two consecutive 'if' statements can be consolidated by separating their conditions with a boolean short-circuit operator.

Example:

void bar() {
 if (x) { // original implementation
 if (y) {
 // do stuff
 }
 }
}

void bar() {
 if (x && y) { // optimized implementation
 // do stuff
 }
}

There are no issues that match your filters.

Category
Status