Sign upLogin

fulldecent/cameralife

View on GitHub
Star

Showing 127 of 127 total issues

Method handleGet has 75 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function handleGet($get, $post, $files, $cookies)
    {
        $nextInstaller = null;
        if (!Models\Database::installedSchemaIsCorrectVersion()) {
            $driver = Models\Database::driverName();
Severity: Major
Found in sources/Controllers/SetupUpgradeController.php - About 3 hrs to fix

    Function imagerotateRightAngle has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
    Open

        private function imagerotateRightAngle($imgSrc, $angle)
    {
        // dimenstion of source image
        $srcX = imagesx($imgSrc);
        $srcY = imagesy($imgSrc);
    Severity: Minor
    Found in sources/Models/Image.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method render has 70 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function render()
    {
        //$counts = $this->statistics->getCounts();
        $popularPhotos = $this->statistics->getPopularPhotos();
        $popularAlbums = $this->statistics->getPopularTags();
    Severity: Major
    Found in sources/Views/StatisticsView.php - About 2 hrs to fix

      Function findChangesOnDisk has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function findChangesOnDisk()
    {
        $retval = array();

        $fileStore = FileStore::fileStoreWithName('photo');
      Severity: Minor
      Found in sources/Models/Folder.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method handleGet has 66 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function handleGet($get, $post, $files, $cookies)
    {
        if (file_exists('../../config.php')) {
            throw new \Exception("Camera Life already appears to be set up, because modules/config.inc exists.");
        }
      Severity: Major
      Found in sources/Controllers/SetupInstallController.php - About 2 hrs to fix

        Method render has 66 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function render()
    {
        echo "<h2>Site change logs</h2>";
        echo "<p class=\"lead\">";
        if ($this->checkpointId > 0) {
        Severity: Major
        Found in sources/Views/AdminLogsView.php - About 2 hrs to fix

          File Folder.php has 270 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          <?php
namespace CameraLife\Models;

/**
 * Folder class.
          Severity: Minor
          Found in sources/Models/Folder.php - About 2 hrs to fix

            Method render has 62 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function render()
    {
        echo "<h2>Settings for " . $this->moduleName . "</h2>\n";
        if (isset($module->about)) {
            echo "<p class=\"lead\">" . $module->about . "</p>\n";
            Severity: Major
            Found in sources/Views/AdminPreferencesView.php - About 2 hrs to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  public function set($key, $value, User $user = null)
    {
        $receipt = null;
        $this->record[$key] = $value;
        Database::update('photos', array($key => $value), 'id=' . $this->record['id']);
              Severity: Major
              Found in sources/Models/Photo.php and 1 other location - About 2 hrs to fix
              sources/Models/Tag.php on lines 32..41

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 130.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  public function set($key, $value, User $user = null)
    {
        $receipt = null;
        $this->record[$key] = $value;
        Database::update('albums', array($key => $value), 'id=' . $this->record['id']);
              Severity: Major
              Found in sources/Models/Tag.php and 1 other location - About 2 hrs to fix
              sources/Models/Photo.php on lines 172..181

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 130.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Function resize has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function resize($filename, $newSize, $quality = 91)
    {
        $baseImage = $this->originalImage;
        $baseSize = $this->size;
              Severity: Minor
              Found in sources/Models/Image.php - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      } else {
            /* Set up grid */
            $start = isset($get['start']) ? $get['start'] : 0;
            $objects = array();
            foreach ($this->model->getFolders() as $folder) {
              Severity: Major
              Found in sources/Controllers/SearchController.php and 1 other location - About 2 hrs to fix
              sources/Controllers/SearchController.php on lines 72..108

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 127.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      if ($photoCount) {
            /* Set up grid */
            $start = isset($get['start']) ? $get['start'] : 0;
            $objects = array();
            foreach ($this->model->getPhotos() as $photo) {
              Severity: Major
              Found in sources/Controllers/SearchController.php and 1 other location - About 2 hrs to fix
              sources/Controllers/SearchController.php on lines 90..108

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 127.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Method render has 57 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function render()
    {
        echo "<h2>Site comments review</h2>";
        echo "<p class=\"lead\">";
        if ($this->checkpointId > 0) {
              Severity: Major
              Found in sources/Views/AdminCommentsView.php - About 2 hrs to fix

                Function render has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function render()
    {
        if ($this->photo->get('status') != 0) {
            echo '<p class="alert alert-danger lead"><strong>Notice:</strong> This photo is not publicly viewable</p>';
        }
                Severity: Minor
                Found in sources/Views/PhotoView.php - About 2 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method handleGet has 54 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function handleGet($get, $post, $files, $cookies)
    {
        $start = isset($get['start']) ? $get['start'] : 0;
        $section = isset($get['section']) ? $get['section'] : null;
        $this->model->setPage($start);
                Severity: Major
                Found in sources/Controllers/FolderController.php - About 2 hrs to fix

                  Method handleGet has 53 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function handleGet($get, $post, $files, $cookies)
    {
        $this->htmlHeader($cookies);

        /* Set up the page view */
                  Severity: Major
                  Found in sources/Controllers/MainPageController.php - About 2 hrs to fix

                    Function render has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function render()
    {
        echo '<div>' . PHP_EOL;
        foreach ($this->openGraphObjects as $view) {
            $openGraphObject = $view;
                    Severity: Minor
                    Found in sources/Views/GridView.php - About 2 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method handleGet has 51 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function handleGet($get, $post, $files, $cookies)
    {
        if (Models\User::currentUser($cookies)->authorizationLevel < 5) {
            throw new \Exception('You are not authorized to view this page');
        }
                    Severity: Major
                    Found in sources/Controllers/AdminLogsController.php - About 2 hrs to fix

                      Method handleGet has 51 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function handleGet($get, $post, $files, $cookies)
    {
        $this->htmlHeader($cookies);

        /* Set up the page view */
                      Severity: Major
                      Found in sources/Controllers/AllTagCollectionsController.php - About 2 hrs to fix
                        Severity
                        Category
                        Status
                        Source
                        Language