Sign upLogin

fulldecent/cameralife

View on GitHub
Star
sources/Models/Photo.php

Summary

Maintainability
F
4 days
Test Coverage

File Photo.php has 514 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
namespace CameraLife\Models;

/**
 * Class Photo provides a front end to working with photos
Severity: Major
Found in sources/Models/Photo.php - About 1 day to fix

    Function loadEXIF has a Cognitive Complexity of 41 (exceeds 5 allowed). Consider refactoring.
    Open

        private function loadEXIF($file)
    {
        $exif = @exif_read_data($file, 'IFD0', true);
        if ($exif === false) {
            return;
    Severity: Minor
    Found in sources/Models/Photo.php - About 6 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method loadEXIF has 98 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function loadEXIF($file)
    {
        $exif = @exif_read_data($file, 'IFD0', true);
        if ($exif === false) {
            return;
    Severity: Major
    Found in sources/Models/Photo.php - About 3 hrs to fix

      Photo has 29 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class Photo extends IndexedModel
{
    public $record;

    public $image;
      Severity: Minor
      Found in sources/Models/Photo.php - About 3 hrs to fix

        Function getRelated has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

            public function getRelated()
    {
        //todo pass in referrer
        global $_SERVER;
        $retval = array($this->getFolder());
        Severity: Minor
        Found in sources/Models/Photo.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method generateThumbnail has 43 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function generateThumbnail()
    {
        $this->loadImage(); // sets $this->EXIF and $this-record
        if ($this->record['modified'] == '1') {
            $this->record['modified'] = null; // legacy before 2.7
        Severity: Minor
        Found in sources/Models/Photo.php - About 1 hr to fix

          Method getRelated has 42 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function getRelated()
    {
        //todo pass in referrer
        global $_SERVER;
        $retval = array($this->getFolder());
          Severity: Minor
          Found in sources/Models/Photo.php - About 1 hr to fix

            Function getMediaURL has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
            Open

                public function getMediaURL($scale = 'thumbnail')
    {
        $bucket = 'other';
        $path = '';
        if ($scale == 'photo') {
            Severity: Minor
            Found in sources/Models/Photo.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method getMediaURL has 34 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function getMediaURL($scale = 'thumbnail')
    {
        $bucket = 'other';
        $path = '';
        if ($scale == 'photo') {
            Severity: Minor
            Found in sources/Models/Photo.php - About 1 hr to fix

              Function getContext has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function getContext()
    {
        if (!$this->context) {
            $this->getRelated();
        }
              Severity: Minor
              Found in sources/Models/Photo.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function generateThumbnail has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function generateThumbnail()
    {
        $this->loadImage(); // sets $this->EXIF and $this-record
        if ($this->record['modified'] == '1') {
            $this->record['modified'] = null; // legacy before 2.7
              Severity: Minor
              Found in sources/Models/Photo.php - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function isCacheMissing has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function isCacheMissing()
    {
        if ($this->record['modified'] == '1') {
            return true; //legacy before 2.7
        }
              Severity: Minor
              Found in sources/Models/Photo.php - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  public function set($key, $value, User $user = null)
    {
        $receipt = null;
        $this->record[$key] = $value;
        Database::update('photos', array($key => $value), 'id=' . $this->record['id']);
              Severity: Major
              Found in sources/Models/Photo.php and 1 other location - About 2 hrs to fix
              sources/Models/Tag.php on lines 32..41

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 130.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status