Sign upLogin

fulldecent/cameralife

View on GitHub
Star
sources/Models/Search.php

Summary

Maintainability
C
1 day
Test Coverage

Function photoSortSqlForOption has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    protected function photoSortSqlForOption($option)
    {
        if ($option == 'newest') {
            return 'value desc, photos.id desc';
        } elseif ($option == 'oldest') {
Severity: Minor
Found in sources/Models/Search.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function tagSortSqlForOption has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    protected function tagSortSqlForOption($option)
    {
        if ($option == 'newest') {
            return 'albums.id desc';
        } elseif ($option == 'oldest') {
Severity: Minor
Found in sources/Models/Search.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function folderSortSqlForOption has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    protected function folderSortSqlForOption($option)
    {
        if ($option == 'newest') {
            return 'id desc';
        } elseif ($option == 'oldest') {
Severity: Minor
Found in sources/Models/Search.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

        return 'id desc';
Severity: Major
Found in sources/Models/Search.php - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                return 'hits, photos.id';
    Severity: Major
    Found in sources/Models/Search.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

              return 'photos.id desc';
      Severity: Major
      Found in sources/Models/Search.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return 'albums.hits desc';
        Severity: Major
        Found in sources/Models/Search.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                      return 'albums.hits';
          Severity: Major
          Found in sources/Models/Search.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                        return 'hits desc';
            Severity: Major
            Found in sources/Models/Search.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return 'hits';
              Severity: Major
              Found in sources/Models/Search.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                            return 'random()';
                Severity: Major
                Found in sources/Models/Search.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                              return 'random()';
                  Severity: Major
                  Found in sources/Models/Search.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                return 'hits desc';
                    Severity: Major
                    Found in sources/Models/Search.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                              return 'albums.id desc';
                      Severity: Major
                      Found in sources/Models/Search.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                    return 'random()';
                        Severity: Major
                        Found in sources/Models/Search.php - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                     return 'id';
                          Severity: Major
                          Found in sources/Models/Search.php - About 30 mins to fix

                            Similar blocks of code found in 3 locations. Consider refactoring.
                            Open

                                protected function tagSortSqlForOption($option)
    {
        if ($option == 'newest') {
            return 'albums.id desc';
        } elseif ($option == 'oldest') {
                            Severity: Minor
                            Found in sources/Models/Search.php and 2 other locations - About 30 mins to fix
                            sources/Models/Folder.php on lines 177..196
                            sources/Models/Search.php on lines 139..158

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 90.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 3 locations. Consider refactoring.
                            Open

                                protected function folderSortSqlForOption($option)
    {
        if ($option == 'newest') {
            return 'id desc';
        } elseif ($option == 'oldest') {
                            Severity: Minor
                            Found in sources/Models/Search.php and 2 other locations - About 30 mins to fix
                            sources/Models/Folder.php on lines 177..196
                            sources/Models/Search.php on lines 118..137

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 90.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            There are no issues that match your filters.

                            Category
                            Status