fulldump/goconfig

View on GitHub
fill_args.go

Summary

Maintainability
A
2 hrs
Test Coverage

Function FillArgs has 68 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func FillArgs(c interface{}, args []string) error {
    var f = flag.NewFlagSet(os.Args[0], flag.ContinueOnError)
    f.Usage = func() {}
    f.SetOutput(os.Stdout)

Severity: Minor
Found in fill_args.go - About 1 hr to fix

    Avoid deeply nested control flow statements.
    Open

            } else if reflect.Int == i.Kind {
                f.IntVar(i.Ptr.(*int), name_path, i.Value.Interface().(int), i.Usage)
    
            } else if reflect.String == i.Kind {
                f.StringVar(i.Ptr.(*string), name_path, i.Value.Interface().(string), i.Usage)
    Severity: Major
    Found in fill_args.go - About 45 mins to fix

      Function FillArgs has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
      Open

      func FillArgs(c interface{}, args []string) error {
          var f = flag.NewFlagSet(os.Args[0], flag.ContinueOnError)
          f.Usage = func() {}
          f.SetOutput(os.Stdout)
      
      
      Severity: Minor
      Found in fill_args.go - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status