fulldump/goconfig

View on GitHub
fill_environments.go

Summary

Maintainability
C
1 day
Test Coverage

Function FillEnvironments has a Cognitive Complexity of 48 (exceeds 20 allowed). Consider refactoring.
Open

func FillEnvironments(c interface{}) (err error) {

    traverse(c, func(i item) {
        env := strings.ToUpper(strings.Join(i.Path, "_"))
        value := os.Getenv(env)
Severity: Minor
Found in fill_environments.go - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function FillEnvironments has 65 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func FillEnvironments(c interface{}) (err error) {

    traverse(c, func(i item) {
        env := strings.ToUpper(strings.Join(i.Path, "_"))
        value := os.Getenv(env)
Severity: Minor
Found in fill_environments.go - About 1 hr to fix

    Avoid deeply nested control flow statements.
    Open

                if v, err := strconv.ParseFloat(value, 32); nil == err {
                    w := float32(v)
                    set(i.Ptr, &w)
                }
    Severity: Major
    Found in fill_environments.go - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

              } else if reflect.Int64 == i.Kind {
                  if v, err := strconv.ParseInt(value, 10, 64); nil == err {
                      set(i.Ptr, &v)
                  }
      
      
      Severity: Major
      Found in fill_environments.go - About 45 mins to fix

        There are no issues that match your filters.

        Category
        Status