Sign upLogin

fulldump/goconfig

View on GitHub
Star
fill_json.go

Summary

Maintainability
B
6 hrs
Test Coverage

Function unmarshalJSON has a Cognitive Complexity of 41 (exceeds 20 allowed). Consider refactoring.
Open

func unmarshalJSON(data []byte, c interface{}) error {
    if reflect.TypeOf(c).Implements(reflect.TypeOf(new(json.Unmarshaler)).Elem()) {
        if err := json.Unmarshal(data, c); err != nil {
            return errors.New("Bad json file: " + err.Error())
        }
Severity: Minor
Found in fill_json.go - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function unmarshalJSON has 51 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func unmarshalJSON(data []byte, c interface{}) error {
    if reflect.TypeOf(c).Implements(reflect.TypeOf(new(json.Unmarshaler)).Elem()) {
        if err := json.Unmarshal(data, c); err != nil {
            return errors.New("Bad json file: " + err.Error())
        }
Severity: Minor
Found in fill_json.go - About 1 hr to fix

    Avoid deeply nested control flow statements.
    Open

                        if d, err = unmarshalDurationString(tmp); err != nil {
                        return
                    }
    Severity: Major
    Found in fill_json.go - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                          if err := json.Unmarshal(value, &tmp); err != nil {
                        return
                    }
      Severity: Major
      Found in fill_json.go - About 45 mins to fix

        Function unmarshalJSON has 6 return statements (exceeds 4 allowed).
        Open

        func unmarshalJSON(data []byte, c interface{}) error {
    if reflect.TypeOf(c).Implements(reflect.TypeOf(new(json.Unmarshaler)).Elem()) {
        if err := json.Unmarshal(data, c); err != nil {
            return errors.New("Bad json file: " + err.Error())
        }
        Severity: Major
        Found in fill_json.go - About 40 mins to fix

          There are no issues that match your filters.

          Category
          Status