Sign upLogin

functional-data-structure/persistent

View on GitHub
Star

Showing 35 of 35 total issues

Function seq has 122 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function seq(empty, size) {
    const Seq = function (tree) {
        this.tree = tree;
    };
Severity: Major
Found in src/seq.js - About 4 hrs to fix

    Function seq has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
    Open

    export function seq(empty, size) {
    const Seq = function (tree) {
        this.tree = tree;
    };
    Severity: Minor
    Found in src/seq.js - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function intervaltree has 80 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export function intervaltree(empty, M) {
    const atleast = function (k, [_, n]) {
        return k <= n;
    };
    Severity: Major
    Found in src/intervaltree.js - About 3 hrs to fix

      Function indordseq has 76 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export function indordseq(empty, key, size, measure) {
    // Probably needs a total order instead of a measure
    // this causes generality problems in the insert, merge, partition and delete
    // methods
      Severity: Major
      Found in src/indordseq.js - About 3 hrs to fix

        Function ordseq has 65 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        export function ordseq(empty, key) {
    // Probably needs a total order instead of a key measure
    // this causes generality problems in the insert, merge, partition and delete
    // methods
        Severity: Major
        Found in src/ordseq.js - About 2 hrs to fix

          Function splice has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              Seq.prototype.splice = function (start, deleteCount, ...items) {
        const length = this.len();

        if (start < -length || start >= length)
            throw new Error(`wrong start '${start}'`);
          Severity: Minor
          Found in src/seq.js - About 1 hr to fix

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                IntervalTree.prototype.split = function (predicate) {
        const [left, right] = this.tree.split(predicate);
        return [new IntervalTree(left), new IntervalTree(right)];
    };
            Severity: Major
            Found in src/intervaltree.js and 3 other locations - About 1 hr to fix
            src/indordseq.js on lines 46..49
            src/ordseq.js on lines 46..49
            src/seq.js on lines 150..153

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 57.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                IndOrdSeq.prototype.split = function (predicate) {
        const [left, right] = this.tree.split(predicate);
        return [new IndOrdSeq(left), new IndOrdSeq(right)];
    };
            Severity: Major
            Found in src/indordseq.js and 3 other locations - About 1 hr to fix
            src/intervaltree.js on lines 56..59
            src/ordseq.js on lines 46..49
            src/seq.js on lines 150..153

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 57.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                Seq.prototype.split = function (predicate) {
        const [left, right] = this.tree.split(predicate);
        return [new Seq(left), new Seq(right)];
    };
            Severity: Major
            Found in src/seq.js and 3 other locations - About 1 hr to fix
            src/indordseq.js on lines 46..49
            src/intervaltree.js on lines 56..59
            src/ordseq.js on lines 46..49

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 57.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                OrdSeq.prototype.split = function (predicate) {
        const [left, right] = this.tree.split(predicate);
        return [new OrdSeq(left), new OrdSeq(right)];
    };
            Severity: Major
            Found in src/ordseq.js and 3 other locations - About 1 hr to fix
            src/indordseq.js on lines 46..49
            src/intervaltree.js on lines 56..59
            src/seq.js on lines 150..153

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 57.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function intervaltree has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

            export function intervaltree(empty, M) {
    const atleast = function (k, [_, n]) {
        return k <= n;
    };
            Severity: Minor
            Found in src/intervaltree.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                IndOrdSeq.prototype.insertValues = function (values) {
        let s = this;

        for (const value of values) s = s.insert(value);
            Severity: Major
            Found in src/indordseq.js and 3 other locations - About 1 hr to fix
            src/heap.js on lines 24..30
            src/intervaltree.js on lines 82..88
            src/ordseq.js on lines 80..86

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 56.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                OrdSeq.prototype.insertValues = function (values) {
        let s = this;

        for (const value of values) s = s.insert(value);
            Severity: Major
            Found in src/ordseq.js and 3 other locations - About 1 hr to fix
            src/heap.js on lines 24..30
            src/indordseq.js on lines 80..86
            src/intervaltree.js on lines 82..88

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 56.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                IntervalTree.prototype.insertValues = function (values) {
        let s = this;

        for (const value of values) s = s.insert(value);
            Severity: Major
            Found in src/intervaltree.js and 3 other locations - About 1 hr to fix
            src/heap.js on lines 24..30
            src/indordseq.js on lines 80..86
            src/ordseq.js on lines 80..86

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 56.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                Heap.prototype.insertValues = function (values) {
        let s = this;

        for (const value of values) s = s.insert(value);
            Severity: Major
            Found in src/heap.js and 3 other locations - About 1 hr to fix
            src/indordseq.js on lines 80..86
            src/intervaltree.js on lines 82..88
            src/ordseq.js on lines 80..86

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 56.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function heap has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            export function heap(empty, max) {
    const Heap = function (tree) {
        this.tree = tree;
    };
            Severity: Minor
            Found in src/heap.js - About 1 hr to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      if (start < -this.len() || start > this.len())
            throw new Error(`wrong start '${start}'`);
              Severity: Minor
              Found in src/seq.js and 1 other location - About 40 mins to fix
              src/seq.js on lines 93..94

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 48.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      if (end < -this.len() || end > this.len())
            throw new Error(`wrong end '${end}'`);
              Severity: Minor
              Found in src/seq.js and 1 other location - About 40 mins to fix
              src/seq.js on lines 91..92

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 48.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Function indordseq has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

              export function indordseq(empty, key, size, measure) {
    // Probably needs a total order instead of a measure
    // this causes generality problems in the insert, merge, partition and delete
    // methods
              Severity: Minor
              Found in src/indordseq.js - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 6 locations. Consider refactoring.
              Open

                  Seq.prototype.measure = Seq.prototype.len = function () {
        return this.tree.measure();
    };
              Severity: Major
              Found in src/seq.js and 5 other locations - About 35 mins to fix
              src/heap.js on lines 10..12
              src/indordseq.js on lines 18..20
              src/indordseq.js on lines 26..28
              src/ordseq.js on lines 18..20
              src/ordseq.js on lines 26..28

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 46.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Severity
              Category
              Status
              Source
              Language