Sign upLogin

funkygao/cp-ddd-framework

View on GitHub
Star
dddplus-plugin/src/main/java/io/github/dddplus/runtime/registry/PluginClassLoader.java

Summary

Maintainability
A
0 mins
Test Coverage

Method loadClass has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Wontfix

    @Override
    protected Class<?> loadClass(String className, boolean resolve) throws ClassNotFoundException {
        Class clazz = this.findLoadedClass(className);
        if (clazz != null) {
            // 如果类已经加载过，就返回那个已经加载好的类
Severity: Minor
Found in dddplus-plugin/src/main/java/io/github/dddplus/runtime/registry/PluginClassLoader.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method loadClass has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Wontfix

    @Override
    protected Class<?> loadClass(String className, boolean resolve) throws ClassNotFoundException {
        Class clazz = this.findLoadedClass(className);
        if (clazz != null) {
            // 如果类已经加载过，就返回那个已经加载好的类
Severity: Minor
Found in dddplus-plugin/src/main/java/io/github/dddplus/runtime/registry/PluginClassLoader.java - About 1 hr to fix

    Avoid too many return statements within this method.
    Wontfix

            return clazz;
    Severity: Major
    Found in dddplus-plugin/src/main/java/io/github/dddplus/runtime/registry/PluginClassLoader.java - About 30 mins to fix

      Avoid too many return statements within this method.
      Wontfix

                  return clazz;
      Severity: Major
      Found in dddplus-plugin/src/main/java/io/github/dddplus/runtime/registry/PluginClassLoader.java - About 30 mins to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Wontfix

                if (containerFirstClass(className)) {
            clazz = containerClassLoader.loadClass(className);
            if (clazz != null) {
                log.debug("loaded {} with {}", className, containerClassLoader);
                return clazz;
        Severity: Minor
        Found in dddplus-plugin/src/main/java/io/github/dddplus/runtime/registry/PluginClassLoader.java and 1 other location - About 30 mins to fix
        dddplus-plugin/src/main/java/io/github/dddplus/runtime/registry/PluginClassLoader.java on lines 61..68

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 40.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Wontfix

                try {
            clazz = jdkClassLoader.loadClass(className);
            if (clazz != null) {
                // 说明该类是JRE的类
                log.debug("loaded {} with {}", className, jdkClassLoader);
        Severity: Minor
        Found in dddplus-plugin/src/main/java/io/github/dddplus/runtime/registry/PluginClassLoader.java and 1 other location - About 30 mins to fix
        dddplus-plugin/src/main/java/io/github/dddplus/runtime/registry/PluginClassLoader.java on lines 72..78

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 40.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status