Sign upLogin

funkygao/cp-ddd-framework

View on GitHub
Star
dddplus-runtime/src/main/java/io/github/dddplus/runtime/StepsExecTemplate.java

Summary

Maintainability
B
6 hrs
Test Coverage

Method executeSteps has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

    private List<String> executeSteps(String activityCode, List<String> stepCodes, Stack<IRevokableDomainStep> executedSteps, Model model,
                                      SchedulingTaskExecutor taskExecutor, Set<String> asyncStepCodes) throws RuntimeException {
        if (asyncStepCodes == null || taskExecutor == null) {
            // the sentry
            asyncStepCodes = emptyAsyncSteps;
Severity: Minor
Found in dddplus-runtime/src/main/java/io/github/dddplus/runtime/StepsExecTemplate.java - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method executeSteps has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private List<String> executeSteps(String activityCode, List<String> stepCodes, Stack<IRevokableDomainStep> executedSteps, Model model,
                                      SchedulingTaskExecutor taskExecutor, Set<String> asyncStepCodes) throws RuntimeException {
        if (asyncStepCodes == null || taskExecutor == null) {
            // the sentry
            asyncStepCodes = emptyAsyncSteps;
Severity: Minor
Found in dddplus-runtime/src/main/java/io/github/dddplus/runtime/StepsExecTemplate.java - About 1 hr to fix

    Method executeSteps has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        private List<String> executeSteps(String activityCode, List<String> stepCodes, Stack<IRevokableDomainStep> executedSteps, Model model,
                                      SchedulingTaskExecutor taskExecutor, Set<String> asyncStepCodes) throws RuntimeException {
    Severity: Minor
    Found in dddplus-runtime/src/main/java/io/github/dddplus/runtime/StepsExecTemplate.java - About 45 mins to fix

      Method execute has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public final void execute(String activityCode, List<String> stepCodes, Model model,
                              SchedulingTaskExecutor taskExecutor, Set<String> asyncStepCodes) throws RuntimeException {
      Severity: Minor
      Found in dddplus-runtime/src/main/java/io/github/dddplus/runtime/StepsExecTemplate.java - About 35 mins to fix

        Method resolveStepExType has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            private Class resolveStepExType() {
        Class thisClass;
        if (AopUtils.isAopProxy(this)) {
            thisClass = AopUtils.getTargetClass(this);
        } else {
        Severity: Minor
        Found in dddplus-runtime/src/main/java/io/github/dddplus/runtime/StepsExecTemplate.java - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method execute has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Wontfix

            public final void execute(String activityCode, List<String> stepCodes, Model model,
                              SchedulingTaskExecutor taskExecutor, Set<String> asyncStepCodes) throws RuntimeException {
        if (stepCodes == null || stepCodes.isEmpty()) {
            log.warn("Empty steps of activity:{} on {}", activityCode, model);
            return;
        Severity: Minor
        Found in dddplus-runtime/src/main/java/io/github/dddplus/runtime/StepsExecTemplate.java - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status