Sign upLogin

funkygao/cp-ddd-framework

View on GitHub
Star
dddplus-visualization/src/main/java/io/github/dddplus/ast/model/KeyModelEntry.java

Summary

Maintainability
B
6 hrs
Test Coverage

KeyModelEntry has 25 methods (exceeds 20 allowed). Consider refactoring.
Open

@Getter
public class KeyModelEntry {
    private static final int propertiesPerLine = 5;

    private static final Set<String> EMPTY_SET = new HashSet();
Severity: Minor
Found in dddplus-visualization/src/main/java/io/github/dddplus/ast/model/KeyModelEntry.java - About 2 hrs to fix

    Method methodClusters has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public List<List<String>> methodClusters() {
        if (keyBehaviorEntries.size() < 6) {
            // 太少，没必要聚类分析
            return null;
        }
    Severity: Minor
    Found in dddplus-visualization/src/main/java/io/github/dddplus/ast/model/KeyModelEntry.java - About 1 hr to fix

      Method methodClusters has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          public List<List<String>> methodClusters() {
        if (keyBehaviorEntries.size() < 6) {
            // 太少，没必要聚类分析
            return null;
        }
      Severity: Minor
      Found in dddplus-visualization/src/main/java/io/github/dddplus/ast/model/KeyModelEntry.java - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method hasKeyMethod has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          public boolean hasKeyMethod(String methodName) {
        for (KeyBehaviorEntry entry : keyBehaviorEntries) {
            if (entry.getRealMethodName().equals(methodName)) {
                return true;
            }
      Severity: Minor
      Found in dddplus-visualization/src/main/java/io/github/dddplus/ast/model/KeyModelEntry.java - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method producedEvents has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public Set<String> producedEvents() {
        Set<String> result = new TreeSet<>();
        for (KeyBehaviorEntry entry : keyBehaviorEntries) {
            if (entry.produceEvent()) {
                result.addAll(entry.getEvents());
      Severity: Minor
      Found in dddplus-visualization/src/main/java/io/github/dddplus/ast/model/KeyModelEntry.java - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          public int propertiesN() {
        int n = 0;
        for (KeyElement.Type type : properties.keySet()) {
            n += properties.get(type).size();
        }
      Severity: Minor
      Found in dddplus-visualization/src/main/java/io/github/dddplus/ast/model/KeyModelEntry.java and 2 other locations - About 30 mins to fix
      dddplus-visualization/src/main/java/io/github/dddplus/ast/report/KeyFlowReport.java on lines 69..75
      dddplus-visualization/src/main/java/io/github/dddplus/ast/report/KeyUsecaseReport.java on lines 40..46

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 41.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status