Sign upLogin

funkygao/cp-ddd-framework

View on GitHub
Star
dddplus-visualization/src/main/java/io/github/dddplus/bce/CallGraphConfig.java

Summary

Maintainability
D
2 days
Test Coverage

File CallGraphConfig.java has 313 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
 * Copyright DDDplus Authors.
 *
 * Licensed under the Apache License version 2.0, available at http://www.apache.org/licenses/LICENSE-2.0
 */
Severity: Minor
Found in dddplus-visualization/src/main/java/io/github/dddplus/bce/CallGraphConfig.java - About 3 hrs to fix

    Method builtinIgnoreInvokeInstruction has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        private boolean builtinIgnoreInvokeInstruction(MethodVisitor m, InvokeInstruction instruction, CallGraphEntry callGraphEntry) {
        final String calleeMethod = callGraphEntry.getCalleeMethod();
        final String calleeClass = callGraphEntry.getCalleeClazz();
        if (ignore.ignoreClassInnerCall() && m.callerClass.equals(calleeClass)) {
            // 自己调用自己
    Severity: Minor
    Found in dddplus-visualization/src/main/java/io/github/dddplus/bce/CallGraphConfig.java - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method initialize has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

            void initialize() {
            classPatterns = new ArrayList<>(classes.size());
            for (String regex : classes) {
                if (!regex.contains("*")) {
                    regex = "*" + regex;
    Severity: Minor
    Found in dddplus-visualization/src/main/java/io/github/dddplus/bce/CallGraphConfig.java - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method initialize has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            void initialize() {
            classPatterns = new ArrayList<>(classes.size());
            for (String regex : classes) {
                if (!regex.contains("*")) {
                    regex = "*" + regex;
    Severity: Minor
    Found in dddplus-visualization/src/main/java/io/github/dddplus/bce/CallGraphConfig.java - About 1 hr to fix

      Method builtinIgnoreInvokeInstruction has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private boolean builtinIgnoreInvokeInstruction(MethodVisitor m, InvokeInstruction instruction, CallGraphEntry callGraphEntry) {
        final String calleeMethod = callGraphEntry.getCalleeMethod();
        final String calleeClass = callGraphEntry.getCalleeClazz();
        if (ignore.ignoreClassInnerCall() && m.callerClass.equals(calleeClass)) {
            // 自己调用自己
      Severity: Minor
      Found in dddplus-visualization/src/main/java/io/github/dddplus/bce/CallGraphConfig.java - About 1 hr to fix

        Method ignoreCaller has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            boolean ignoreCaller(MethodVisitor m) {
        if (builtinIgnoreCaller(m)) {
            return true;
        }
        Severity: Minor
        Found in dddplus-visualization/src/main/java/io/github/dddplus/bce/CallGraphConfig.java - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

                    return true;
        Severity: Major
        Found in dddplus-visualization/src/main/java/io/github/dddplus/bce/CallGraphConfig.java - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                      return true;
          Severity: Major
          Found in dddplus-visualization/src/main/java/io/github/dddplus/bce/CallGraphConfig.java - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                        return true;
            Severity: Major
            Found in dddplus-visualization/src/main/java/io/github/dddplus/bce/CallGraphConfig.java - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                      return false;
              Severity: Major
              Found in dddplus-visualization/src/main/java/io/github/dddplus/bce/CallGraphConfig.java - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                        return false;
                Severity: Major
                Found in dddplus-visualization/src/main/java/io/github/dddplus/bce/CallGraphConfig.java - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                              return false;
                  Severity: Major
                  Found in dddplus-visualization/src/main/java/io/github/dddplus/bce/CallGraphConfig.java - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                            return false;
                    Severity: Major
                    Found in dddplus-visualization/src/main/java/io/github/dddplus/bce/CallGraphConfig.java - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                  return false;
                      Severity: Major
                      Found in dddplus-visualization/src/main/java/io/github/dddplus/bce/CallGraphConfig.java - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                    return true;
                        Severity: Major
                        Found in dddplus-visualization/src/main/java/io/github/dddplus/bce/CallGraphConfig.java - About 30 mins to fix

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                                      for (String regex : callerPackages) {
                if (!regex.contains("*")) {
                    regex = "*" + regex + "*";
                }
                callerPackagePatterns.add(FileSystems.getDefault().getPathMatcher("glob:" + regex));
                          Severity: Minor
                          Found in dddplus-visualization/src/main/java/io/github/dddplus/bce/CallGraphConfig.java and 1 other location - About 45 mins to fix
                          dddplus-visualization/src/main/java/io/github/dddplus/bce/CallGraphConfig.java on lines 335..340

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 56.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                                      for (String regex : calleePackages) {
                if (!regex.contains("*")) {
                    regex = "*" + regex + "*";
                }
                calleePackagePatterns.add(FileSystems.getDefault().getPathMatcher("glob:" + regex));
                          Severity: Minor
                          Found in dddplus-visualization/src/main/java/io/github/dddplus/bce/CallGraphConfig.java and 1 other location - About 45 mins to fix
                          dddplus-visualization/src/main/java/io/github/dddplus/bce/CallGraphConfig.java on lines 323..328

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 56.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                  if (calleeMethod.startsWith("get") && args == 0) {
            log.debug("getter ignored: {}.{} -> {}.{}", m.callerClass, m.callerMethod, calleeClass, calleeMethod);
            return true;
        }
                          Severity: Minor
                          Found in dddplus-visualization/src/main/java/io/github/dddplus/bce/CallGraphConfig.java and 1 other location - About 30 mins to fix
                          dddplus-visualization/src/main/java/io/github/dddplus/bce/CallGraphConfig.java on lines 178..181

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 42.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                  if (calleeMethod.startsWith("set") && args == 1) {
            log.debug("setter ignored: {}.{} -> {}.{}", m.callerClass, m.callerMethod, calleeClass, calleeMethod);
            return true;
        }
                          Severity: Minor
                          Found in dddplus-visualization/src/main/java/io/github/dddplus/bce/CallGraphConfig.java and 1 other location - About 30 mins to fix
                          dddplus-visualization/src/main/java/io/github/dddplus/bce/CallGraphConfig.java on lines 174..177

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 42.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          There are no issues that match your filters.

                          Category
                          Status