Sign upLogin

funkygao/cp-ddd-framework

View on GitHub
Star

Showing 146 of 168 total issues

Method parse has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    public static CallGraphReport parse(String[] jarPaths, CallGraphConfig config) throws IOException {
        CallGraphReport report = new CallGraphReport(config);
        for (String jarPath : jarPaths) {
            File jarFile = new File(jarPath);
            if (!jarFile.exists()) {
Severity: Minor
Found in dddplus-visualization/src/main/java/io/github/dddplus/bce/CallGraphParser.java - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method hasKeyMethod has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    public boolean hasKeyMethod(String methodName) {
        for (KeyBehaviorEntry entry : keyBehaviorEntries) {
            if (entry.getRealMethodName().equals(methodName)) {
                return true;
            }
Severity: Minor
Found in dddplus-visualization/src/main/java/io/github/dddplus/ast/model/KeyModelEntry.java - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method invokeExtension has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    private R invokeExtension(ExtensionDef extensionDef, final Method method, Object[] args) throws Throwable {
        try {
            ExtensionContext context = null;
            if (interceptor != null) {
                context = new ExtensionContext(extensionDef.getCode(), extensionDef.getExtensionBean(), method, args);
Severity: Minor
Found in dddplus-runtime/src/main/java/io/github/dddplus/runtime/ExtensionInvocationHandler.java - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method parse has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    public KeyRelationEntry parse(AnnotationExpr keyRelation) {
        KeyRelationEntry entry = new KeyRelationEntry();
        entry.setJavadoc(JavaParserUtil.javadocFirstLineOf(leftClassDeclaration));
        entry.setLeftClass(leftClassDeclaration.getNameAsString());
        entry.setLeftClassPackageName(JavaParserUtil.packageName(leftClassDeclaration));
Severity: Minor
Found in dddplus-visualization/src/main/java/io/github/dddplus/ast/parser/KeyRelationAnnotationParser.java - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method renderNodes has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    private CallGraphRenderer renderNodes() {
        Map<String, CallGraphReport.Record> mergedNodes = callGraphReport.displayNodes();
        for (String clazz : mergedNodes.keySet()) {
            nodes++;
            CallGraphReport.Record record = mergedNodes.get(clazz);
Severity: Minor
Found in dddplus-visualization/src/main/java/io/github/dddplus/ast/view/CallGraphRenderer.java - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

/*
 * Copyright DDDplus Authors.
 *
 * Licensed under the Apache License version 2.0, available at http://www.apache.org/licenses/LICENSE-2.0
 */
Severity: Minor
Found in dddplus-spec/src/main/java/io/github/dddplus/model/spcification/OrSpecification.java and 1 other location - About 55 mins to fix
dddplus-spec/src/main/java/io/github/dddplus/model/spcification/AndSpecification.java on lines 1..31

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 63.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

/*
 * Copyright DDDplus Authors.
 *
 * Licensed under the Apache License version 2.0, available at http://www.apache.org/licenses/LICENSE-2.0
 */
Severity: Minor
Found in dddplus-spec/src/main/java/io/github/dddplus/model/spcification/AndSpecification.java and 1 other location - About 55 mins to fix
dddplus-spec/src/main/java/io/github/dddplus/model/spcification/OrSpecification.java on lines 1..31

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 63.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

            for (String regex : callerPackages) {
                if (!regex.contains("*")) {
                    regex = "*" + regex + "*";
                }
                callerPackagePatterns.add(FileSystems.getDefault().getPathMatcher("glob:" + regex));
Severity: Minor
Found in dddplus-visualization/src/main/java/io/github/dddplus/bce/CallGraphConfig.java and 1 other location - About 45 mins to fix
dddplus-visualization/src/main/java/io/github/dddplus/bce/CallGraphConfig.java on lines 335..340

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                for (KeyRuleEntry entry : keyModelEntry.getKeyRuleEntries()) {
                    append(TAB).append(TAB)
                            .append(entry.displayNameWithRemark())
                            .append("(")
                            .append(entry.displayRefer())
Severity: Minor
Found in dddplus-visualization/src/main/java/io/github/dddplus/ast/view/PlainTextRenderer.java and 1 other location - About 45 mins to fix
dddplus-visualization/src/main/java/io/github/dddplus/ast/view/PlainTextRenderer.java on lines 137..146

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            for (KeyBehaviorEntry entry : keyModelEntry.getKeyBehaviorEntries()) {
                append(TAB).append(TAB)
                        .append(entry.displayNameWithRemark())
                        .append("(")
                        .append(entry.displayArgs())
Severity: Minor
Found in dddplus-visualization/src/main/java/io/github/dddplus/ast/view/PlainTextRenderer.java and 1 other location - About 45 mins to fix
dddplus-visualization/src/main/java/io/github/dddplus/ast/view/PlainTextRenderer.java on lines 150..159

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

            for (String regex : calleePackages) {
                if (!regex.contains("*")) {
                    regex = "*" + regex + "*";
                }
                calleePackagePatterns.add(FileSystems.getDefault().getPathMatcher("glob:" + regex));
Severity: Minor
Found in dddplus-visualization/src/main/java/io/github/dddplus/bce/CallGraphConfig.java and 1 other location - About 45 mins to fix
dddplus-visualization/src/main/java/io/github/dddplus/bce/CallGraphConfig.java on lines 323..328

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method executeSteps has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    private List<String> executeSteps(String activityCode, List<String> stepCodes, Stack<IRevokableDomainStep> executedSteps, Model model,
                                      SchedulingTaskExecutor taskExecutor, Set<String> asyncStepCodes) throws RuntimeException {
Severity: Minor
Found in dddplus-runtime/src/main/java/io/github/dddplus/runtime/StepsExecTemplate.java - About 45 mins to fix

    Method visit has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        @Override
    public void visit(final MethodDeclaration methodDeclaration, final KeyUsecaseReport report) {
        super.visit(methodDeclaration, report);

        if (!methodDeclaration.isAnnotationPresent(KeyUsecase.class)) {
    Severity: Minor
    Found in dddplus-visualization/src/main/java/io/github/dddplus/ast/KeyUsecaseAstNodeVisitor.java - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method writeKeyUsecaseClazzDefinition has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        private PlainTextRenderer writeKeyUsecaseClazzDefinition(String actor) {
        append(actor).append(NEWLINE);
        for (KeyUsecaseEntry entry : model.getKeyUsecaseReport().sortedActorKeyUsecases(actor)) {
            append(TAB);
            if (!entry.displayOut().isEmpty()) {
    Severity: Minor
    Found in dddplus-visualization/src/main/java/io/github/dddplus/ast/view/PlainTextRenderer.java - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

                                if (first) {
                                entry.setRootClass(classExpr.getTypeAsString());
                                first = false;
                            } else {
                                entry.addExtraRootClass(classExpr.getTypeAsString());
    Severity: Major
    Found in dddplus-visualization/src/main/java/io/github/dddplus/ast/parser/AggregateAnnotationParser.java - About 45 mins to fix

      Method visit has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          @Override
    public void visit(final MethodDeclaration methodDeclaration, final KeyFlowReport report) {
        super.visit(methodDeclaration, report);

        if (!methodDeclaration.isAnnotationPresent(KeyFlow.class)) {
      Severity: Minor
      Found in dddplus-visualization/src/main/java/io/github/dddplus/ast/KeyFlowAstNodeVisitor.java - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid deeply nested control flow statements.
      Open

                              if (clusters.get(i).isEmpty()) {
                            continue;
                        }
      Severity: Major
      Found in dddplus-visualization/src/main/java/io/github/dddplus/ast/view/PlainTextRenderer.java - About 45 mins to fix

        Method add has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            public KeyRelationReport add(KeyRelationEntry entry) {
        // dup check
        for (KeyRelationEntry relationEntry : relationEntries) {
            if (relationEntry.sameAs(entry)) {
                throw new RuntimeException(String.format("Dup Key Relation: existed %s, new entry %s",
        Severity: Minor
        Found in dddplus-visualization/src/main/java/io/github/dddplus/ast/report/KeyRelationReport.java - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public static TypeDeclaration getTypeDeclaration(Node node) {
        while (!(node instanceof TypeDeclaration)) {
            if (node.getParentNode().isPresent()) {
                node = node.getParentNode().get();
            } else {
        Severity: Minor
        Found in dddplus-visualization/src/main/java/io/github/dddplus/ast/parser/JavaParserUtil.java and 1 other location - About 40 mins to fix
        dddplus-visualization/src/main/java/io/github/dddplus/ast/parser/JavaParserUtil.java on lines 74..85

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 50.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                for (KeyBehaviorEntry entry : keyModelEntry.getKeyBehaviorEntries()) {
            sqlList.add(String.format(EntityInsert,
                    aggregateEntry.getName(),
                    keyModelEntry.getClassName(),
                    EntityKind.BEHAVIOR.value,
        Severity: Minor
        Found in dddplus-visualization/src/main/java/io/github/dddplus/ast/model/dumper/sqlite/SqliteDumper.java and 1 other location - About 40 mins to fix
        dddplus-visualization/src/main/java/io/github/dddplus/ast/model/dumper/sqlite/SqliteDumper.java on lines 104..112

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 50.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Severity
        Category
        Status
        Source
        Language