Sign upLogin

funkygao/cp-ddd-framework

View on GitHub
Star

Showing 146 of 168 total issues

Avoid too many return statements within this method.
Open

        return false;
Severity: Major
Found in dddplus-visualization/src/main/java/io/github/dddplus/ast/PublicMethodAstNodeVisitor.java - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

            return false;
    Severity: Major
    Found in dddplus-visualization/src/main/java/io/github/dddplus/bce/CallGraphConfig.java - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

              return false;
      Severity: Major
      Found in dddplus-visualization/src/main/java/io/github/dddplus/bce/CallGraphConfig.java - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                        return;
        Severity: Major
        Found in dddplus-visualization/src/main/java/io/github/dddplus/ast/KeyRuleAstNodeVisitor.java - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                          return;
          Severity: Major
          Found in dddplus-visualization/src/main/java/io/github/dddplus/ast/ClassMethodDistributionAstNodeVisitor.java - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                        return false;
            Severity: Major
            Found in dddplus-visualization/src/main/java/io/github/dddplus/bce/CallGraphConfig.java - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                      return false;
              Severity: Major
              Found in dddplus-visualization/src/main/java/io/github/dddplus/bce/CallGraphConfig.java - About 30 mins to fix

                Identical blocks of code found in 3 locations. Consider refactoring.
                Open

                            for (int i = 0; i < dirPaths.length; i++) {
                dirs[i] = new File(dirPaths[i]);
            }
                Severity: Minor
                Found in dddplus-maven-plugin/src/main/java/io/github/dddplus/maven/EnforcerMojo.java and 2 other locations - About 30 mins to fix
                dddplus-maven-plugin/src/main/java/io/github/dddplus/maven/ClassHierarchyMojo.java on lines 52..54
                dddplus-maven-plugin/src/main/java/io/github/dddplus/maven/ModelingVisualizationMojo.java on lines 56..58

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 40.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 3 locations. Consider refactoring.
                Open

                            for (int i = 0; i < dirPaths.length; i++) {
                dirs[i] = new File(dirPaths[i]);
            }
                Severity: Minor
                Found in dddplus-maven-plugin/src/main/java/io/github/dddplus/maven/ModelingVisualizationMojo.java and 2 other locations - About 30 mins to fix
                dddplus-maven-plugin/src/main/java/io/github/dddplus/maven/ClassHierarchyMojo.java on lines 52..54
                dddplus-maven-plugin/src/main/java/io/github/dddplus/maven/EnforcerMojo.java on lines 45..47

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 40.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 3 locations. Consider refactoring.
                Open

                            for (int i = 0; i < dirPaths.length; i++) {
                dirs[i] = new File(dirPaths[i]);
            }
                Severity: Minor
                Found in dddplus-maven-plugin/src/main/java/io/github/dddplus/maven/ClassHierarchyMojo.java and 2 other locations - About 30 mins to fix
                dddplus-maven-plugin/src/main/java/io/github/dddplus/maven/EnforcerMojo.java on lines 45..47
                dddplus-maven-plugin/src/main/java/io/github/dddplus/maven/ModelingVisualizationMojo.java on lines 56..58

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 40.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Avoid too many return statements within this method.
                Open

                            return false;
                Severity: Major
                Found in dddplus-visualization/src/main/java/io/github/dddplus/bce/CallGraphConfig.java - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                  return true;
                  Severity: Major
                  Found in dddplus-visualization/src/main/java/io/github/dddplus/ast/PublicMethodAstNodeVisitor.java - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                return;
                    Severity: Major
                    Found in dddplus-visualization/src/main/java/io/github/dddplus/ast/KeyRuleAstNodeVisitor.java - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                      return;
                      Severity: Major
                      Found in dddplus-visualization/src/main/java/io/github/dddplus/ast/enforcer/AllowedAccessorsEnforcer.java - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                    return true;
                        Severity: Major
                        Found in dddplus-visualization/src/main/java/io/github/dddplus/bce/CallGraphConfig.java - About 30 mins to fix

                          Method containsNode has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                              public boolean containsNode(@NonNull String clazzName) {
        for (Record node : callerRecords()) {
            if (node.sameAs(clazzName)) {
                return true;
            }
                          Severity: Minor
                          Found in dddplus-visualization/src/main/java/io/github/dddplus/ast/report/CallGraphReport.java - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Method getTarget has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                              static Object getTarget(Object bean) throws BootstrapException {
        if (!AopUtils.isAopProxy(bean)) {
            return bean;
        } else if (AopUtils.isCglibProxy(bean)) {
            try {
                          Severity: Minor
                          Found in dddplus-runtime/src/main/java/io/github/dddplus/runtime/registry/InternalAopUtils.java - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Method resolveExtClazz has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                              private void resolveExtClazz() {
        ResolvableType baseRouterClazz = ResolvableType.forClass(this.baseRouterClazz).getSuperType();
        for (int i = 0; i < MAX_INHERITANCE_DEPTH; i++) {
            for (ResolvableType resolvableType : baseRouterClazz.getGenerics()) {
                if (IDomainExtension.class.isAssignableFrom(resolvableType.resolve())) {
                          Severity: Minor
                          Found in dddplus-runtime/src/main/java/io/github/dddplus/runtime/registry/RouterDef.java - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Method writeClazzDefinition has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                              private void writeClazzDefinition(AggregateEntry aggregateEntry, KeyModelEntry keyModelEntry) throws SQLException, ClassNotFoundException {
        List<String> sqlList = new LinkedList<>();
        for (KeyElement.Type type : keyModelEntry.types()) {
            for (KeyPropertyEntry propertyEntry : keyModelEntry.keyPropertiesByType(type)) {
                sqlList.add(String.format(EntityInsert,
                          Severity: Minor
                          Found in dddplus-visualization/src/main/java/io/github/dddplus/ast/model/dumper/sqlite/SqliteDumper.java - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Method hasProducer has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                              public boolean hasProducer(KeyEventEntry entry) {
        if (getKeyModelReport().hasProducer(entry)) {
            return true;
        }
                          Severity: Minor
                          Found in dddplus-visualization/src/main/java/io/github/dddplus/ast/model/ReverseEngineeringModel.java - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Severity
                          Category
                          Status
                          Source
                          Language