Sign upLogin

fuzeman/trakt.py

View on GitHub
Star

Showing 249 of 249 total issues

Similar blocks of code found in 9 locations. Consider refactoring.
Open

    @authenticated
    def episodes(self, username, sort=None, store=None, **kwargs):
        return self.get(
            username, 'episodes',
Severity: Major
Found in trakt/interfaces/users/watchlist.py and 8 other locations - About 35 mins to fix
trakt/interfaces/users/ratings.py on lines 74..77
trakt/interfaces/users/ratings.py on lines 83..86
trakt/interfaces/users/ratings.py on lines 92..95
trakt/interfaces/users/ratings.py on lines 101..104
trakt/interfaces/users/ratings.py on lines 110..113
trakt/interfaces/users/watchlist.py on lines 77..80
trakt/interfaces/users/watchlist.py on lines 86..89
trakt/interfaces/users/watchlist.py on lines 95..98

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

    @authenticated
    def episodes(self, username, rating=None, store=None, **kwargs):
        return self.get(
            username, 'episodes',
Severity: Major
Found in trakt/interfaces/users/ratings.py and 8 other locations - About 35 mins to fix
trakt/interfaces/users/ratings.py on lines 74..77
trakt/interfaces/users/ratings.py on lines 83..86
trakt/interfaces/users/ratings.py on lines 92..95
trakt/interfaces/users/ratings.py on lines 101..104
trakt/interfaces/users/watchlist.py on lines 77..80
trakt/interfaces/users/watchlist.py on lines 86..89
trakt/interfaces/users/watchlist.py on lines 95..98
trakt/interfaces/users/watchlist.py on lines 104..107

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

    @authenticated
    def seasons(self, username, sort=None, store=None, **kwargs):
        return self.get(
            username, 'seasons',
Severity: Major
Found in trakt/interfaces/users/watchlist.py and 8 other locations - About 35 mins to fix
trakt/interfaces/users/ratings.py on lines 74..77
trakt/interfaces/users/ratings.py on lines 83..86
trakt/interfaces/users/ratings.py on lines 92..95
trakt/interfaces/users/ratings.py on lines 101..104
trakt/interfaces/users/ratings.py on lines 110..113
trakt/interfaces/users/watchlist.py on lines 77..80
trakt/interfaces/users/watchlist.py on lines 86..89
trakt/interfaces/users/watchlist.py on lines 104..107

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

    @authenticated
    def seasons(self, username, rating=None, store=None, **kwargs):
        return self.get(
            username, 'seasons',
Severity: Major
Found in trakt/interfaces/users/ratings.py and 8 other locations - About 35 mins to fix
trakt/interfaces/users/ratings.py on lines 74..77
trakt/interfaces/users/ratings.py on lines 83..86
trakt/interfaces/users/ratings.py on lines 92..95
trakt/interfaces/users/ratings.py on lines 110..113
trakt/interfaces/users/watchlist.py on lines 77..80
trakt/interfaces/users/watchlist.py on lines 86..89
trakt/interfaces/users/watchlist.py on lines 95..98
trakt/interfaces/users/watchlist.py on lines 104..107

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

    @authenticated
    def movies(self, username, sort=None, store=None, **kwargs):
        return self.get(
            username, 'movies',
Severity: Major
Found in trakt/interfaces/users/watchlist.py and 8 other locations - About 35 mins to fix
trakt/interfaces/users/ratings.py on lines 74..77
trakt/interfaces/users/ratings.py on lines 83..86
trakt/interfaces/users/ratings.py on lines 92..95
trakt/interfaces/users/ratings.py on lines 101..104
trakt/interfaces/users/ratings.py on lines 110..113
trakt/interfaces/users/watchlist.py on lines 86..89
trakt/interfaces/users/watchlist.py on lines 95..98
trakt/interfaces/users/watchlist.py on lines 104..107

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function off has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def off(self, event=None, func=None):
        self.__log('off(event: %s, func: %s)', repr(event), repr(func))

        self.__ensure_constructed()
Severity: Minor
Found in trakt/core/emitter.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

            return User._construct(client, keys, item, **kwargs)
Severity: Major
Found in trakt/mapper/core/base.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                return Person._construct(client, keys, item, **kwargs)
    Severity: Major
    Found in trakt/mapper/core/base.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return items
      Severity: Major
      Found in trakt/core/pagination.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return data
        Severity: Major
        Found in trakt/interfaces/base/__init__.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                      return Comment._construct(client, keys, item, **kwargs)
          Severity: Major
          Found in trakt/mapper/core/base.py - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                        return WatchedProgress._construct(client, item, **kwargs)
            Severity: Major
            Found in trakt/mapper/core/base.py - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                          return False
              Severity: Major
              Found in trakt/core/http.py - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                            return CollectionProgress._construct(client, item, **kwargs)
                Severity: Major
                Found in trakt/mapper/core/base.py - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                              return CustomList._construct(client, keys, item, **kwargs)
                  Severity: Major
                  Found in trakt/mapper/core/base.py - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                                    return False
                    Severity: Major
                    Found in trakt/core/http.py - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                                  return PublicList._construct(client, keys, item, **kwargs)
                      Severity: Major
                      Found in trakt/mapper/core/base.py - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                                    return True
                        Severity: Major
                        Found in trakt/core/http.py - About 30 mins to fix

                          Function episode has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                              def episode(cls, client, item, parse_show=False, **kwargs):
        if not item:
            return None

        if 'episode' in item:
                          Severity: Minor
                          Found in trakt/mapper/summary.py - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function get has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                              def get(self, username, media=None, sort=None, store=None, extended=None,
            page=None, per_page=None, **kwargs):

        # Build parameters
        params = []
                          Severity: Minor
                          Found in trakt/interfaces/users/watchlist.py - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Severity
                          Category
                          Status
                          Source
                          Language