Sign upLogin

fuzeman/trakt.py

View on GitHub
Star
trakt/interfaces/scrobble.py

Summary

Maintainability
C
1 day
Test Coverage

File scrobble.py has 311 lines of code (exceeds 250 allowed). Consider refactoring.
Open

from trakt.core.helpers import dictfilter
from trakt.interfaces.base import Interface, authenticated, application


class ScrobbleInterface(Interface):
Severity: Minor
Found in trakt/interfaces/scrobble.py - About 3 hrs to fix

    Function action has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        def action(self, action, movie=None, show=None, episode=None, progress=0.0, **kwargs):
        """Perform scrobble action.

        :param action: Action to perform (either :code:`start`, :code:`pause` or :code:`stop`)
        :type action: :class:`~python:str`
    Severity: Minor
    Found in trakt/interfaces/scrobble.py - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function action has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def action(self, action, movie=None, show=None, episode=None, progress=0.0, **kwargs):
    Severity: Minor
    Found in trakt/interfaces/scrobble.py - About 45 mins to fix

      Function start has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def start(self, movie=None, show=None, episode=None, progress=0.0, **kwargs):
      Severity: Minor
      Found in trakt/interfaces/scrobble.py - About 35 mins to fix

        Function stop has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def stop(self, movie=None, show=None, episode=None, progress=0.0, **kwargs):
        Severity: Minor
        Found in trakt/interfaces/scrobble.py - About 35 mins to fix

          Function pause has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def pause(self, movie=None, show=None, episode=None, progress=0.0, **kwargs):
          Severity: Minor
          Found in trakt/interfaces/scrobble.py - About 35 mins to fix

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                @application
    @authenticated
    def start(self, movie=None, show=None, episode=None, progress=0.0, **kwargs):
        """Send the scrobble "start" action.
            Severity: Major
            Found in trakt/interfaces/scrobble.py and 2 other locations - About 50 mins to fix
            trakt/interfaces/scrobble.py on lines 240..337
            trakt/interfaces/scrobble.py on lines 342..446

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 36.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                @application
    @authenticated
    def stop(self, movie=None, show=None, episode=None, progress=0.0, **kwargs):
        """Send the scrobble "stop" action.
            Severity: Major
            Found in trakt/interfaces/scrobble.py and 2 other locations - About 50 mins to fix
            trakt/interfaces/scrobble.py on lines 136..235
            trakt/interfaces/scrobble.py on lines 240..337

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 36.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                @application
    @authenticated
    def pause(self, movie=None, show=None, episode=None, progress=0.0, **kwargs):
        """Send the scrobble "pause' action.
            Severity: Major
            Found in trakt/interfaces/scrobble.py and 2 other locations - About 50 mins to fix
            trakt/interfaces/scrobble.py on lines 136..235
            trakt/interfaces/scrobble.py on lines 342..446

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 36.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status