Sign upLogin

fuzeman/trakt.py

View on GitHub
Star
trakt/mapper/core/base.py

Summary

Maintainability
B
6 hrs
Test Coverage

Function construct has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    def construct(cls, client, media, item, keys=None, **kwargs):
        if keys is None:
            _, keys = cls.get_ids(media, item)

        if media == 'movie':
Severity: Minor
Found in trakt/mapper/core/base.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function get_ids has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    def get_ids(media, item, parent=None):
        if not item:
            return None, []

        ids = item.get('ids', {})
Severity: Minor
Found in trakt/mapper/core/base.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def construct(cls, client, media, item, keys=None, **kwargs):
Severity: Minor
Found in trakt/mapper/core/base.py - About 35 mins to fix

    Avoid too many return statements within this function.
    Open

                return User._construct(client, keys, item, **kwargs)
    Severity: Major
    Found in trakt/mapper/core/base.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                  return Person._construct(client, keys, item, **kwargs)
      Severity: Major
      Found in trakt/mapper/core/base.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                    return Comment._construct(client, keys, item, **kwargs)
        Severity: Major
        Found in trakt/mapper/core/base.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                      return WatchedProgress._construct(client, item, **kwargs)
          Severity: Major
          Found in trakt/mapper/core/base.py - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                        return CollectionProgress._construct(client, item, **kwargs)
            Severity: Major
            Found in trakt/mapper/core/base.py - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                          return CustomList._construct(client, keys, item, **kwargs)
              Severity: Major
              Found in trakt/mapper/core/base.py - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                            return PublicList._construct(client, keys, item, **kwargs)
                Severity: Major
                Found in trakt/mapper/core/base.py - About 30 mins to fix

                  There are no issues that match your filters.

                  Category
                  Status